-
-
Notifications
You must be signed in to change notification settings - Fork 387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][ADD] crm_lead_product #255
Conversation
add filter for open opportunities in pipeline by product report [IMP] Extend test coverage
def29e9
to
ab17f8d
Compare
ab17f8d
to
ef99c98
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Improve Code
crm_lead_product/__init__.py
Outdated
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
|
||
from . import models | ||
from . import report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ageficent Add new blank line
crm_lead_product/report/__init__.py
Outdated
@@ -0,0 +1,3 @@ | |||
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | |||
|
|||
from . import crm_product_report |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@ageficent I noticed that when you drill down from the report 'Pipeline by product' to the individual line, the form view should contain the lead_id, to facilitate to the user the possibility to navigate to the actual lead. Also, I believe that we should have, for lines, a name_get method so that it does not shows just the id, but, for example, the name of the product or the name of the product category |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍🏻
{ | ||
'name': 'Lead Line Product', | ||
'version': '11.0.1.0.0', | ||
'category': 'Customer Relationship Management', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor change. category: 'Sales'
/ocabot merge |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at b250b84. Thanks a lot for contributing to OCA. ❤️ PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into |
Back port of module crm_lead_product from v12 to v11