Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[11.0][ADD] crm_lead_product #255

Closed
wants to merge 5 commits into from

Conversation

AdriaGForgeFlow
Copy link

Back port of module crm_lead_product from v12 to v11

AdriaGForgeFlow and others added 3 commits January 28, 2019 08:56
add filter for open opportunities in pipeline by product report

[IMP] Extend test coverage
Copy link
Member

@Nikul-Chaudhary Nikul-Chaudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improve Code

# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from . import models
from . import report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ageficent Add new blank line

@@ -0,0 +1,3 @@
# License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).

from . import crm_product_report
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@JordiBForgeFlow
Copy link
Sponsor Member

@ageficent I noticed that when you drill down from the report 'Pipeline by product' to the individual line, the form view should contain the lead_id, to facilitate to the user the possibility to navigate to the actual lead.

image

Also, I believe that we should have, for lines, a name_get method so that it does not shows just the id, but, for example, the name of the product or the name of the product category

image

Copy link
Member

@cristinamartinrod cristinamartinrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

{
'name': 'Lead Line Product',
'version': '11.0.1.0.0',
'category': 'Customer Relationship Management',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change. category: 'Sales'

@JordiBForgeFlow
Copy link
Sponsor Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Rebased to 11.0-ocabot-merge-pr-255-by-jbeficent-bump-no, awaiting test results.

OCA-git-bot added a commit that referenced this pull request Jul 3, 2019
Signed-off-by jbeficent
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at b250b84. Thanks a lot for contributing to OCA. ❤️

PS: Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged into 11.0.

@OCA-git-bot OCA-git-bot closed this Jul 3, 2019
@MiquelRForgeFlow MiquelRForgeFlow deleted the 11.0-add-crm_lead_product branch July 4, 2019 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants