Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New module : crm_lead_sequence #256

Closed
wants to merge 2 commits into from

Conversation

sbejaoui
Copy link

@sbejaoui sbejaoui commented Feb 7, 2019

No description provided.

Copy link
Member

@Nikul-Chaudhary Nikul-Chaudhary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Improved Code

'data/crm_lead_sequence.xml',
'views/crm_lead.xml'
],
'demo': [],
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbejaoui If not any file then remove it.

<field name="model">crm.lead</field>
<field name="inherit_id" ref="crm.crm_case_form_view_oppor"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='name']" position="before">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbejaoui IMO Use direct Field here

<field name="ref" attrs="{'invisible': [('ref', '=', False)]}"/>

<field name="inherit_id" ref="crm.crm_case_kanban_view_leads"/>
<field name="arch" type="xml">
<xpath expr="//field[@name='name']" position="before">
<field name="ref"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@pedrobaeza
Copy link
Member

This module is the same as https://github.com/OCA/crm/tree/10.0/crm_lead_code, being migrated to v12 in #253, and I prefer to talk about code instead of sequence for avoiding the misunderstanding about sequence as order key (sequence field in several models).

@sbejaoui
Copy link
Author

sbejaoui commented Feb 8, 2019

Thank you @pedrobaeza , I was looking for it.

you can close this PR.

@sbidoul sbidoul closed this Feb 8, 2019
@sbidoul sbidoul deleted the 12.0-crm_lead_sequence-sbj branch February 8, 2019 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants