Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[12.0][MIG] crm_claim_type: Migration to 12.0 #284

Merged
merged 9 commits into from Jun 18, 2019

Conversation

Tardo
Copy link
Member

@Tardo Tardo commented Jun 17, 2019

PR based on: #193
Rebased some commits

Cc @Tecnativa

@pedrobaeza pedrobaeza added this to the 12.0 milestone Jun 17, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 17, 2019
20 tasks
Copy link
Member

@tbaden tbaden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the work 👍
I did a code review: LGTM, if you like some optional changes.

</field>
</record>

<record id="crm_stage_claim_type_tree" model="ir.ui.view">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional:
use original id (crm_claim_stage_tree)

</field>
</record>

<record id="crm_stage_claim_type_form" model="ir.ui.view">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

optional:
use original id (crm_claim_stage_form)

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on runbot

@pedrobaeza
Copy link
Member

/ocabot merge

@OCA-git-bot
Copy link
Contributor

Rebased to 12.0-ocabot-merge-pr-284-by-pedrobaeza-bump-no, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4adf9ec into OCA:12.0 Jun 18, 2019
OCA-git-bot added a commit that referenced this pull request Jun 18, 2019
Signed-off-by pedrobaeza
@OCA-git-bot
Copy link
Contributor

Merged at 5447e08. Don't worry if GitHub says there are unmerged commits: it is due to a rebase before merge. All commits of this PR have been merged on the main branch.

@pedrobaeza pedrobaeza deleted the 12.0-mig-crm_claim_type branch June 19, 2019 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants