Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] new addon crm_location #29

Merged
merged 17 commits into from Jul 29, 2015
Merged

[ADD] new addon crm_location #29

merged 17 commits into from Jul 29, 2015

Conversation

Endika
Copy link

@Endika Endika commented Jun 8, 2015

CRM location

This module introduces a better zip.

It enables zip, city, state and country auto-completion on lead


This module introduces a better zip.

It enables zip, city, state and country auto-completion on lead and companies.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Companies is already included in base_location.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Creation section Installation and mention that this module depends on module base_location that it's located on OCA/partner-contact repository.

@Endika
Copy link
Author

Endika commented Jun 29, 2015

Ok?

self.state_id = self.location_id.state_id
self.country_id = self.location_id.country_id

better_zip_id = fields.Many2one(
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why both fields? You should remove this one

@pedrobaeza
Copy link
Member

You have to put a message here when you make the changes, because in contrary we are not warned about the changes.

@Endika
Copy link
Author

Endika commented Jun 29, 2015

Update

@pedrobaeza
Copy link
Member

👍 Thanks

@rafaelbn
Copy link
Member

👍

@lmignon
Copy link
Sponsor

lmignon commented Jun 30, 2015

@Endika Thank you for your PR. One issue: When you select a partner in the crm.lead form, the zip_id from the partner is not copied on the lead.

Steps to reproduce:

  • Update partner Agrolait and select a value for 'city completion'
  • Create a lead and select Agrolait as partner

Current behavior:

  • 'City completion' remains empty

Expected behavior:

  • 'City completion' should be filled with the one from Agrolait.

@Endika
Copy link
Author

Endika commented Jun 30, 2015

Ok @lmignon thx

@lmignon
Copy link
Sponsor

lmignon commented Jun 30, 2015

@Endika Thank you for the changes but there is another problem. When I create a lead I've an exception.`(tested on runbot)

  File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3110043-29-bc7dd8/openerp/api.py", line 239, in wrapper
    return new_api(self, *args, **kwargs)
TypeError: 'NoneType' object is not callable

image

'website': 'http://www.antiun.com',
'license': 'AGPL-3',
'demo': [],
'test': [],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza always says that if it is empty, do not write it down 😉

@oihane
Copy link
Contributor

oihane commented Jul 1, 2015

@Endika I think you should rebase, because it is now fixed error that was causing runbot check to fail

@Endika
Copy link
Author

Endika commented Jul 17, 2015

@oihane OK

@tafaRU
Copy link
Member

tafaRU commented Jul 29, 2015

@Endika thanks for the module, LGTM and also tested 👍

Could you just please explain me how options="{'create_name_field': 'city'} works from a technical point of view?

@Endika
Copy link
Author

Endika commented Jul 29, 2015

@tafaRU create_name_field corresponds to a model dictionary key.

@pedrobaeza
Copy link
Member

create_name_field is used for specyfing the field that will fill the record name.

@pedrobaeza
Copy link
Member

👍

pedrobaeza added a commit that referenced this pull request Jul 29, 2015
@pedrobaeza pedrobaeza merged commit 888f848 into OCA:8.0 Jul 29, 2015
@tafaRU
Copy link
Member

tafaRU commented Aug 24, 2015

@Endika @pedrobaeza thanks for your explanations.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants