New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] new addon crm_location #29
Conversation
|
||
This module introduces a better zip. | ||
|
||
It enables zip, city, state and country auto-completion on lead and companies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Companies is already included in base_location.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Creation section Installation
and mention that this module depends on module base_location that it's located on OCA/partner-contact repository.
Ok? |
self.state_id = self.location_id.state_id | ||
self.country_id = self.location_id.country_id | ||
|
||
better_zip_id = fields.Many2one( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why both fields? You should remove this one
You have to put a message here when you make the changes, because in contrary we are not warned about the changes. |
Update |
👍 Thanks |
👍 |
@Endika Thank you for your PR. One issue: When you select a partner in the crm.lead form, the zip_id from the partner is not copied on the lead. Steps to reproduce:
Current behavior:
Expected behavior:
|
Ok @lmignon thx |
@Endika Thank you for the changes but there is another problem. When I create a lead I've an exception.`(tested on runbot)
|
'website': 'http://www.antiun.com', | ||
'license': 'AGPL-3', | ||
'demo': [], | ||
'test': [], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@pedrobaeza always says that if it is empty, do not write it down 😉
@Endika I think you should rebase, because it is now fixed error that was causing runbot check to fail |
@oihane OK |
@Endika thanks for the module, LGTM and also tested 👍 Could you just please explain me how |
@tafaRU |
|
👍 |
[ADD] new addon crm_location
@Endika @pedrobaeza thanks for your explanations. |
CRM location
This module introduces a better zip.
It enables zip, city, state and country auto-completion on lead