Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[13.0][MIG] crm_claim_code #313

Closed
wants to merge 21 commits into from

Conversation

newtratip
Copy link
Member

No description provided.

@mamcode
Copy link
Member

mamcode commented Jun 13, 2020

@newtratip Thanks for this migration I have tested the module with the pr #316 and it is ok. I think you should add your name to the list of contributors. I will approve this PR when pr #316 is merged and you rebase this branch with 13.0 and travis is in green with tests. It would also be nice
if you rewrite the history and squash the translations commits https://github.com/OCA/maintainer-tools/wiki/Merge-commits-in-pull-requests#mergesquash-the-commits-generated-by-transifex

@mamcode
Copy link
Member

mamcode commented Jun 22, 2020

@newtratip Can you rebase on 13.0 please ?

@rousseldenis rousseldenis added this to the 13.0 milestone Jun 22, 2020
@OCA-git-bot OCA-git-bot mentioned this pull request Jun 22, 2020
17 tasks
@newtratip newtratip force-pushed the 13.0-mig-crm_claim_code branch 3 times, most recently from c938c01 to dfa4620 Compare October 2, 2020 11:35
Rodrigo Macedo and others added 2 commits October 2, 2020 18:37
@ernestotejeda
Copy link
Member

Code review: OK

@newtratip , Rebase on 13.0, please.

@ernestotejeda
Copy link
Member

@newtratip ¿May I create a new PR by superseding this one?

@newtratip
Copy link
Member Author

@ernestotejeda

yes, you can.
Sorry for late reply. I have no time to do this. please continue it.

Thank!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet