[ADD] crm_claim_ref_smartbutton: Smart-button for referenced claims #38

pedrobaeza · 2015-07-31T17:56:40Z

Smart-button for referenced claims

This module adds an smart-button in the models that can be referenced in a
claim with the number of linked claims and a shortcut to them.

Usage

Go to any record that can be referenced in a claim, and you will see in a
smart-button called linked claims a number indicating the number of
claims that reference this record. Clicking on the button, it will navigate
to a list of these claims.

If you click New on the claim list, the created claim will be automatically
linked to the referenced record.

Known issues / Roadmap

The check for seeing if the opened model is one of the possible referenced
models is done on each view request, so this hits very little, but a bit,
the overall performance of the system.

pedrobaeza · 2015-07-31T17:59:48Z

@StefanRijnhart, I think you would enjoy this piece of code.

Smart-button for referenced claims ================================== This module adds an smart-button in the models that can be referenced in a claim with the number of linked claims and a shortcut to them. Usage ===== Go to any record that can be referenced in a claim, and you will see in a smart-button called _linked claims_ a number indicating the number of claims that reference this record. Clicking on the button, it will navigate to a list of these claims. If you click _New_ on the claim list, the created claim will be automatically linked to the referenced record. Known issues / Roadmap ====================== * The check for seeing if the opened model is one of the possible referenced models is done on each view request, so this hits very little, but a bit, the overall performance of the system.

anajuaristi · 2015-08-01T12:44:35Z

Tested functionally on runbot, it works
👍 RTM (ready to merge) from my functional point of view.
Very usefull module

oihane · 2015-08-03T07:44:02Z

👍
Although coveralls is failing.

pedrobaeza · 2015-08-03T14:10:34Z

There's an error opening "My dashboard" menu entry that it's solved in this PR to Odoo: odoo/odoo#7855

pedrobaeza · 2015-08-04T07:45:30Z

Patch merged on Odoo, so everything is OK!

… word

pedrobaeza · 2015-08-04T12:15:32Z

Added tests!

oihane · 2015-08-04T12:48:53Z

@pedrobaeza tests are failing

oihane · 2015-08-04T12:53:59Z

crm_claim_ref_smartbutton/tests/test_crm_claim_ref_smartbutton.py

+        self.assertTrue(
+            xml_field, "Smart-button not added to %s view" % model_name)
+        # Test the smart-button existence for a model not linked
+        for model in self.env['ir.model'].search():


Don't you have to put [] in order to search every model?

pedrobaeza · 2015-08-04T13:34:35Z

Sorry, unfinished code was submitted.

lmignon · 2015-08-10T12:57:09Z

crm_claim_ref_smartbutton/__openerp__.py

+    ],
+    "category": "Customer Relationship Management",
+    "installable": True,
+    "pre_init_hook": "pre_init_hook",


@pedrobaeza hooks are only called at installation time not each time the server start. Therefore your monkey-patch will be only applied once. IOW your patch will no more be applied after the first time your sever will be restarted after the installation. odoo/odoo@4105b5f#diff-9f65b6631806b04e785c2acdf3854285R151

@pedrobaeza The solution is may be to create a fake model and implement the _register_hook method to apply your monkey patch each time the module is loaded in the registry at startup time. https://github.com/odoo/odoo/blob/8.0/openerp/modules/loading.py#L446

You're only seeing half of the solution. This is the possible scenarios:

You can start without the module copied in the addons path before the server starts.

Or have it copied in addons path and start the server. This code prevents the monkey-patching: https://github.com/OCA/crm/pull/38/files#diff-df883f43bfa35a2a786daa20cc741e74R103

When you install the module, in one or another case, the monkey-patching is done via the pre-hook script (https://github.com/OCA/crm/pull/38/files#diff-ec1e94af671fc87f2d489b43471edae2R14).

Next time you start the server, the same line that previously prevents the monkey-patching, now does it (https://github.com/OCA/crm/pull/38/files#diff-df883f43bfa35a2a786daa20cc741e74R103).

When you uninstall the module, the monkey-patching is undone here: https://github.com/OCA/crm/pull/38/files#diff-ec1e94af671fc87f2d489b43471edae2R20

@pedrobaeza Sorry for the noise.. haven't see the full solution. IMO, the solution can be simplified by monkey-patching in a _register_hook BaseModel in a fake non stored Model. In this way we no more need the pre_init_hook and monkey patching is done in one place.

Can you draft the proposition with the fake model? Take into account that this module can cover any linkable model in claims.

class CrmClaimMonkeyPatcher(models.TransientModel): _name = 'cr.claim.mockey.patcher' _auto = False # doesn't create table in database def _register_hook(self, cr): BaseModel.base_fields_view_get = base_fields_view_get BaseModel.fields_view_get = fields_view_get_crm_claim

pedrobaeza · 2015-08-22T00:38:01Z

I have followed @lmignon's advice and implement the monkey-patching in a model with _auto=False and now the monkey-patching is only done when the module is installed, and now is multi-db aware thanks to a list that registers the dbs where the module is installed.

…dule is not installed

pedrobaeza · 2015-08-22T09:13:12Z

@antespi you can check now

gurneyalex · 2015-08-25T12:53:47Z

crm_claim_ref_smartbutton/README.rst

+Smart-button for referenced claims
+==================================
+
+This module adds an smart-button in the models that can be referenced in a


s/ an / a /

pedrobaeza · 2015-08-27T01:20:07Z

All remarks are solved, so this is ready to be merged.

hbrunn · 2015-09-08T21:42:08Z

@pedrobaeza nice solution. But the full table scan on res_request_link for every view load (can't this be ormcached?) bothers me, as well as the unconditional monkey patches.

How about monkey patching only existing models' fields_view_get that show up in res.request.link, and also monkey patch https://github.com/OCA/OCB/blob/8.0/openerp/modules/registry.py#L486 in _register_hook in order to collect new models popping up which are in res.request.link? Then you can do the work in fields_view_get unconditionally.

Then some details like adding/removing the patch in res.request.link#create/unlink

rafaelbn · 2015-10-07T08:38:58Z

@pedrobaeza I think you should answer @hbrunn and I will make a test in runbot in order to merge. OK?

rafaelbn · 2015-12-15T23:14:13Z

Tested un runbot 👍

anajuaristi · 2016-02-09T16:03:19Z

Hi, could we merge this one? I think it could be very usefull have it available to use instead of staying as PR.

pedrobaeza · 2016-02-09T16:05:07Z

@anajuaristi, there's already some suggestions on how to implement certain things that I haven't applied yet due to lack of time, so better to stay as a PR yet.

StefanRijnhart · 2016-02-09T19:25:37Z

Agree with @hbrunn mainly about the monkeypatching (that will 'affect' instances with this module sitting uninstalled in the module path. Setting to WIP as per @pedrobaeza's last comment.

StefanRijnhart · 2016-02-09T19:27:39Z

BTW. can a project admin create milestones for the older releases, so that we don't have to use the tag?

pedrobaeza · 2016-06-06T10:07:53Z

cc @Tecnativa

nhomar · 2016-06-06T10:17:54Z

crm_claim_ref_smartbutton/models/base_model.py

+from lxml import etree
+
+
+base_fields_view_get = models.BaseModel.fields_view_get


Why the monkeypatch?

Did you know you can inherit BaseModel Normally right?

BTW, due to this has an static folder this code will try to be executed.

Can you try do the feature without monkeypatch?

nhomar · 2016-06-06T10:19:28Z

IOH: This kind of changes without tests (changes that modifiy the general behavior of odoo) are really dangerous, I prefer some minimal test cases .

nhomar · 2016-06-06T10:20:05Z

Monkeypatched for me is a 👎 but it is a 👍 for the functionality.

pedrobaeza · 2016-06-06T10:28:33Z

It's a WIP still, @nhomar. I will use another technique.

rafaelbn · 2016-07-21T20:12:30Z

This is a WIP, @pedrobaeza are you going to continue it?

yajo · 2016-08-19T11:27:06Z

crm_claim_ref_smartbutton/README.rst

+Bugs are tracked on `GitHub Issues <https://github.com/OCA/crm/issues>`_.
+In case of trouble, please check there if your issue has already been reported.
+If you spotted it first, help us smashing it by providing a detailed and welcomed feedback
+`here <https://github.com/OCA/crm/issues/new?body=module:%20crm_claim_ref_smartbutton%0Aversion:%208.0%0A%0A**Steps%20to%20reproduce**%0A-%20...%0A%0A**Current%20behavior**%0A%0A**Expected%20behavior**>`_.


Please update with beautier newer template 😊

rafaelbn · 2016-10-04T16:01:47Z

I guess you would like to finish this PR but will it be possible? Anyone can take this work and try to finish it?

pedrobaeza force-pushed the 8.0-crm_claim_ref_smartbutton branch from 4179aa2 to 472b5b6 Compare July 31, 2015 17:59

pedrobaeza force-pushed the 8.0-crm_claim_ref_smartbutton branch from 472b5b6 to 32972d6 Compare August 1, 2015 11:42

pedrobaeza mentioned this pull request Aug 3, 2015

[FIX] board: Put keyword argument on fields_view_get super call odoo/odoo#7855

Closed

[IMP/FIX] crm_claim_ref_smartbutton: Lighten headers and fix "coding"…

f486c48

… word

oihane reviewed Aug 4, 2015
View reviewed changes

[IMP] crm_claim_ref_smartbutton: Added tests

19afa24

pedrobaeza force-pushed the 8.0-crm_claim_ref_smartbutton branch from 3118753 to 19afa24 Compare August 4, 2015 13:31

pedrobaeza mentioned this pull request Aug 6, 2015

[FIX] fields_view_get super arguments odoo/odoo#7933

Closed

lmignon reviewed Aug 10, 2015
View reviewed changes

pedrobaeza force-pushed the 8.0-crm_claim_ref_smartbutton branch 5 times, most recently from cb576be to 2984d91 Compare August 22, 2015 00:37

[IMP] crm_claim_ref_smartbutton: Don't make monkey-patching if the mo…

dd1d789

…dule is not installed

pedrobaeza force-pushed the 8.0-crm_claim_ref_smartbutton branch from 2984d91 to dd1d789 Compare August 22, 2015 00:38

gurneyalex reviewed Aug 25, 2015
View reviewed changes

hbrunn added the question label Sep 8, 2015

StefanRijnhart added work in progress and removed 8.0 needs review labels Feb 9, 2016

StefanRijnhart added the 8.0 label Feb 9, 2016

max3903 modified the milestone: 8.0 Mar 10, 2016

nhomar reviewed Jun 6, 2016
View reviewed changes

yajo reviewed Aug 19, 2016
View reviewed changes

pedrobaeza closed this Aug 16, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[ADD] crm_claim_ref_smartbutton: Smart-button for referenced claims #38

[ADD] crm_claim_ref_smartbutton: Smart-button for referenced claims #38

pedrobaeza commented Jul 31, 2015

pedrobaeza commented Jul 31, 2015

anajuaristi commented Aug 1, 2015

oihane commented Aug 3, 2015

pedrobaeza commented Aug 3, 2015

pedrobaeza commented Aug 4, 2015

pedrobaeza commented Aug 4, 2015

oihane commented Aug 4, 2015

oihane Aug 4, 2015

pedrobaeza commented Aug 4, 2015

lmignon Aug 10, 2015

lmignon Aug 10, 2015

pedrobaeza Aug 10, 2015

lmignon Aug 10, 2015

pedrobaeza Aug 10, 2015

lmignon Aug 10, 2015

pedrobaeza commented Aug 22, 2015

pedrobaeza commented Aug 22, 2015

gurneyalex Aug 25, 2015

pedrobaeza commented Aug 27, 2015

hbrunn commented Sep 8, 2015

rafaelbn commented Oct 7, 2015

rafaelbn commented Dec 15, 2015

anajuaristi commented Feb 9, 2016

pedrobaeza commented Feb 9, 2016

StefanRijnhart commented Feb 9, 2016

StefanRijnhart commented Feb 9, 2016

pedrobaeza commented Jun 6, 2016

nhomar Jun 6, 2016

nhomar commented Jun 6, 2016

nhomar commented Jun 6, 2016

pedrobaeza commented Jun 6, 2016

rafaelbn commented Jul 21, 2016

yajo Aug 19, 2016

rafaelbn commented Oct 4, 2016

		from lxml import etree


		base_fields_view_get = models.BaseModel.fields_view_get

[ADD] crm_claim_ref_smartbutton: Smart-button for referenced claims #38

[ADD] crm_claim_ref_smartbutton: Smart-button for referenced claims #38

Conversation

pedrobaeza commented Jul 31, 2015

Smart-button for referenced claims

Usage

Known issues / Roadmap

pedrobaeza commented Jul 31, 2015

anajuaristi commented Aug 1, 2015

oihane commented Aug 3, 2015

pedrobaeza commented Aug 3, 2015

pedrobaeza commented Aug 4, 2015

pedrobaeza commented Aug 4, 2015

oihane commented Aug 4, 2015

Choose a reason for hiding this comment

pedrobaeza commented Aug 4, 2015

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Aug 22, 2015

pedrobaeza commented Aug 22, 2015

Choose a reason for hiding this comment

pedrobaeza commented Aug 27, 2015

hbrunn commented Sep 8, 2015

rafaelbn commented Oct 7, 2015

rafaelbn commented Dec 15, 2015

anajuaristi commented Feb 9, 2016

pedrobaeza commented Feb 9, 2016

StefanRijnhart commented Feb 9, 2016

StefanRijnhart commented Feb 9, 2016

pedrobaeza commented Jun 6, 2016

Choose a reason for hiding this comment

nhomar commented Jun 6, 2016

nhomar commented Jun 6, 2016

pedrobaeza commented Jun 6, 2016

rafaelbn commented Jul 21, 2016

Choose a reason for hiding this comment

rafaelbn commented Oct 4, 2016