Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] crm_secondary_salesperson: Migration to 13.0 #385

Merged
merged 10 commits into from
Mar 10, 2021
Merged

[13.0][MIG] crm_secondary_salesperson: Migration to 13.0 #385

merged 10 commits into from
Mar 10, 2021

Conversation

victoralmau
Copy link
Member

@victoralmau victoralmau commented Mar 9, 2021 •
edited
Loading

Migration to 13.0 + Add tests

Please @joao-p-marques and @CarlosRoca13 can you review it?

@Tecnativa TT28669

@victoralmau victoralmau force-pushed the 13.0-mig-crm_secondary_salesperson branch from 2923417 to 9f8ecc2 Compare March 9, 2021 10:36
@victoralmau victoralmau marked this pull request as ready for review March 9, 2021 10:37
joao-p-marques
joao-p-marques reviewed Mar 9, 2021
View reviewed changes
Copy link
Member

@joao-p-marques joao-p-marques left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small doubt with the tests, but overall everything seems OK with the code and functionally 👍

crm_secondary_salesperson/tests/test_crm_lead.py Outdated Show resolved Hide resolved
@victoralmau victoralmau force-pushed the 13.0-mig-crm_secondary_salesperson branch from 9f8ecc2 to 0a16cad Compare March 9, 2021 12:23
@rousseldenis rousseldenis added this to the 13.0 milestone Mar 10, 2021
@rousseldenis rousseldenis mentioned this pull request Mar 10, 2021
Closed
17 tasks
rousseldenis
rousseldenis approved these changes Mar 10, 2021
View reviewed changes
Copy link
Sponsor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@HaraldPanten
Copy link
Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 13.0-ocabot-merge-pr-385-by-HaraldPanten-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 557ae22 into OCA:13.0 Mar 10, 2021
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3bcff7f. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelsavegnago marcelsavegnago marcelsavegnago approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@HaraldPanten HaraldPanten HaraldPanten approved these changes

@CarlosRoca13 CarlosRoca13 CarlosRoca13 approved these changes

@joao-p-marques joao-p-marques joao-p-marques approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@victoralmau @HaraldPanten @OCA-git-bot @marcelsavegnago @rousseldenis @CarlosRoca13 @joao-p-marques @oca-travis @oca-transbot