Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MIG][15.0]crm_lead_vat: Migration V15 #420

Closed
wants to merge 34 commits into from
Closed

[MIG][15.0]crm_lead_vat: Migration V15 #420

wants to merge 34 commits into from

Conversation

bizzappdev
Copy link
Contributor

No description provided.

@bizzappdev bizzappdev mentioned this pull request Feb 10, 2022
Closed
15 tasks
@bizzappdev bizzappdev force-pushed the 15.0-mig-crm-lead-vat-BAD-RUS branch 2 times, most recently from a1a834b to 082e6e5 Compare February 14, 2022 12:39
@bizzappdev bizzappdev changed the title [WIP][MIG][15.0]crm_lead_vat: Migration V15 [MIG][15.0]crm_lead_vat: Migration V15 Mar 2, 2022
@yajo
Copy link
Member

yajo commented Mar 30, 2022

/ocabot migration crm_lead_vat

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Mar 30, 2022
yajo
yajo requested changes Mar 30, 2022
View reviewed changes
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@moduon MT-518

crm_lead_vat/models/crm_lead.py Outdated
Comment on lines 6 to 8
from odoo.addons.crm.models.crm_lead import PARTNER_ADDRESS_FIELDS_TO_SYNC

# Add vat in list
PARTNER_ADDRESS_FIELDS_TO_SYNC += ["vat"]

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code is loaded when the module is scanned by Odoo, at boot.

🛑 Thus you shouldn't alter this global variable (actually a pseudo-constant, as stated by the UPPER_CASE name).

crm_lead_vat/models/crm_lead.py Outdated
Comment on lines 22 to 27
result = super(Lead, self)._prepare_values_from_partner(partner)
if not partner:
return result
if partner.vat:
result["vat"] = partner.vat
result = super(Lead, self)._prepare_address_values_from_partner(partner)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Following from the above comment, you should undo this diff and leave it as it was before.

This way, we only alter the behavior when a database has the module installed, and not only when it is available.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes are done.

@rafaelbn
Copy link
Member

@bizzappdev are you going to continue with this PR? Thanks! 😄

@RikiBalthazar
Copy link

def _prepare_address_values_from_partner(self, partner):
"""Recover VAT from partner if available."""
result = super(Lead, self)._prepare_address_values_from_partner(partner)
if not partner:
return result
if partner.vat:
result["vat"] = partner.vat
return result

Hello!
I made this work changing "_prepare_values_from_partner" whit > "_prepare_address_values_from_partner"
I hope this helps

yajo and others added 20 commits May 4, 2022 14:21
@yajo
Add crm_lead_vat.
784dd07
@yajo
Fix onchange misbehavior.
c891d4d
@yajo
Drop dependency on odoo/odoo#8899.
7fe3e50
@yajo
Fix onchange.
2e387df
@yajo
Add field to opportunities form too.
bd92253
@yajo
Add translation. Still missing terms.
fcd5987
@yajo
Fix creator URL.
fd41123
@pedrobaeza
[FIX] Author
bd367cf
@oca-transbot
OCA Transbot updated translations from Transifex
a74bdd4
@sbidoul
[FIX] remove en.po that was erroneously created by transbot
312224c
@oihane
[FIX] crm_lead_vat: fix onchange error
7ac4507
@sbidoul
remove obsolete .pot files [ci skip]
d3d12b2
@oca-travis
[UPD] Update crm_lead_vat.pot
55b088b
@oihane
[MIG] crm_lead_vat: Migration to 12.0
d207a27
@oca-travis
[UPD] Update crm_lead_vat.pot
c7dc01d
@oca-transbot
Update translation files
85c73bc 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-12.0/crm-12.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_vat/
@OCA-git-bot
[UPD] README.rst
c0943d4
Translated using Weblate (Portuguese (Brazil))
def5d02 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-12.0/crm-12.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_vat/pt_BR/
@eLBati
Translated using Weblate (Italian)
175d0c4 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-12.0/crm-12.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_vat/it/
@eLBati
FIX crm_lead_vat tests after odoo/odoo@e183393
8403ab8
primes2h and others added 13 commits May 4, 2022 14:21
@primes2h
Translated using Weblate (Italian)
2eaf01b 
Currently translated at 100.0% (3 of 3 strings)

Translation: crm-12.0/crm-12.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-12-0/crm-12-0-crm_lead_vat/it/
@newtratip
[IMP] crm_lead_vat: black, isort
97d66ec
@newtratip
[13.0][MIG] crm_lead_vat
0405b7d
@oca-travis
[UPD] Update crm_lead_vat.pot
9f2fd65
@skeller1
[FIX] Clean up license links
7ef725a
@pedrobaeza
[IMP] crm_lead_vat: Improve description
7c48432 
Closes OCA#354
@OCA-git-bot
[UPD] README.rst
05b4d50
@redapureskill
[MIG] crm_lead_vat: Migration to 14.0
670e68e
@oca-travis
[UPD] Update crm_lead_vat.pot
4d3ecd0
@OCA-git-bot
[UPD] README.rst
0d157d7
@OCA-git-bot
crm_lead_vat 14.0.1.1.0
0498ed9
@oca-transbot
Update translation files
89bb876 
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate.

Translation: crm-14.0/crm-14.0-crm_lead_vat
Translate-URL: https://translation.odoo-community.org/projects/crm-14-0/crm-14-0-crm_lead_vat/
@bizzappdev
[IMP] crm_lead_vat : black, isort, prettier
9ceb82f
@bizzappdev bizzappdev force-pushed the 15.0-mig-crm-lead-vat-BAD-RUS branch 2 times, most recently from 2bb42e1 to 05b7be2 Compare May 4, 2022 08:54
@bizzappdev bizzappdev force-pushed the 15.0-mig-crm-lead-vat-BAD-RUS branch from 05b7be2 to f605f2c Compare May 4, 2022 08:57
@github-actions
Copy link

github-actions bot commented Sep 4, 2022

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Sep 4, 2022
@github-actions github-actions bot closed this Oct 9, 2022
@OCA-git-bot OCA-git-bot mentioned this pull request Mar 20, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yajo yajo yajo requested changes

Assignees
No one assigned
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet