Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] crm_sector #72

Merged
merged 1 commit into from
Dec 22, 2015
Merged

[ADD] crm_sector #72

merged 1 commit into from
Dec 22, 2015

Conversation

JavierIniesta
Copy link

This module adds the concept of economic sector for leads and opportunities.

@rafaelbn
Copy link
Member

cc @yajo

mission is to support the collaborative development of Odoo features and
promote its widespread use.

To contribute to this module, please visit http://odoo-community.org.

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https (please update your template with the newest here: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst

@elicoidal
Copy link

other than small details LGTM

@JavierIniesta JavierIniesta force-pushed the 8.0-crm_sector branch 3 times, most recently from 2f92233 to 8023a28 Compare December 21, 2015 10:27
@JavierIniesta
Copy link
Author

Readme, error message and tests updated.


.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
:alt: Try me on Runbot
:target: https://runbot.odoo-community.org/runbot/134/8.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

111

@JavierIniesta
Copy link
Author

Changes:

  • repo id for runbot in README
  • oldname added to sector_id
  • @api.one added to _check_sectors function
  • @api.model added to _lead_create_contact function

@rafaelbn
Copy link
Member

Please change postition in oportunity view

2015-12-22_15-31-27

Tested and functionality 👍

@JavierIniesta
Copy link
Author

Position changed in opportunity view.

@rafaelbn
Copy link
Member

Rnbot error not related

Tested 👍

@JMODaERP
Copy link

I´ve tested in runbot 👍

@yajo
Copy link
Member

yajo commented Dec 22, 2015

👍

rafaelbn added a commit that referenced this pull request Dec 22, 2015
@rafaelbn rafaelbn merged commit 39af2c0 into OCA:8.0 Dec 22, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants