[8.0][crm_lead_firstname] Link crm and partner_firstname modules. #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Travis fails, runbot fails, I cannot test it. |
|
It should work now. |
This module adds the lastname field to leads and converts current contact name into contact firstname. Allows to transfer that from and to res.partner objects.
Without respecting the order, the user could get to a situation where you are updating a field without lastname to set `firstname=False, lastname="something"` and fail because Odoo started by `firstname` and that lead to a temporary situation where no names are set and `EmptyNamesError` gets raised. With this patch, you force Odoo to write first the field with value, whith avoids that situation and always works.
|
I rebased to make runbot rebuild, let's see if today it works. |
|
Runbot says: |
|
I tested functionality and it's OK! Thanks 👍 |
|
#75 (comment) fixed in OCA/partner-contact#250 |
| if not is_company and partner_id: | ||
| partner = self.env["res.partner"].browse(partner_id) | ||
| partner.update( | ||
| OrderedDict( |
There was a problem hiding this comment.
Why do you use this strange construction?
There was a problem hiding this comment.
You should write the same commit text as comment for clarifying it to the next code reader
|
All fixed. |
|
👍 |
1 similar comment
|
👍 |
rafaelbn
added a commit
that referenced
this pull request
Feb 29, 2016
[8.0][crm_lead_firstname] Link crm and partner_firstname modules.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This module adds the lastname field to leads and converts current contact name into contact firstname.
Allows to transfer that from and to res.partner objects.
@rafaelbn