Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.0][crm_phonecall_category] Phonecall category #79

Merged
merged 2 commits into from
Feb 29, 2016
Merged

[8.0][crm_phonecall_category] Phonecall category #79

merged 2 commits into from
Feb 29, 2016

Conversation

yajo
Copy link
Member

@yajo yajo commented Feb 24, 2016

This module shows the already-existing categ_id field for crm.phonecall tree and search views.

@rafaelbn

This module shows the already-existing `categ_id` field for `crm.phonecall` tree and search views.
@yajo
Copy link
Member Author

yajo commented Feb 25, 2016

Runbot's ❌ is fixed in OCA/partner-contact#250

@rafaelbn
Copy link
Member

Great, OCA/partner-contact#250 is merged so runbot must be fixed
Functionality tested 👍

==================

This module extends the functionality of CRM phone calls to support showing the
category directly in their tree view and allow you to search by that field too.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/allow/allowing

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't interesting to allow to group to by the category?

@yajo
Copy link
Member Author

yajo commented Feb 26, 2016

Remarks fixed.

@pedrobaeza
Copy link
Member

👍

<xpath expr="//field[@name='user_id']" position="after">
<field name="categ_id"/>
</xpath>
<xpath expr="//group[@string='Group By']">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yajo position is not mandatory?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oks.. 👍

rafaelbn added a commit that referenced this pull request Feb 29, 2016
[8.0][crm_phonecall_category] Phonecall category
@rafaelbn rafaelbn merged commit 2ea80ef into OCA:8.0 Feb 29, 2016
@yajo yajo deleted the crm_phonecall_category branch February 29, 2016 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants