-
-
Notifications
You must be signed in to change notification settings - Fork 390
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.0] TRANSIFEX Support #84
Conversation
- secure: FFyWAwM7PmCbOI8lSIFNkDknkspQQv3sD8aKyz5tTPtAmLdALEj+MaPsuZJS9PoHzqjrylrhHEg+lB5lNjHR+3t2oOgHZb44l+mob22N6WDB5nag11jnBI+q0hGEHrbYNe5r3mnNvUQKXSfmjyKE181755fnOvhc88x5DnHXo0Q= | ||
|
||
matrix: | ||
- TRANSIFEX="1" | ||
- VERSION="8.0" ODOO_REPO="odoo/odoo" LINT_CHECK="0" | ||
- VERSION="8.0" ODOO_REPO="OCA/OCB" LINT_CHECK="0" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be:
- LINT_CHECK="1"
- TRANSIFEX="1"
- TESTS="1" ODOO_REPO="odoo/odoo"
- TESTS="1" ODOO_REPO="OCA/OCB"
and there is a dash missing before coveralls at the end of the file. Otherwise 👍 |
Done! Had to amend my last commit because I wasn't using my regular PC, and I forgot to configure git user and email. That's why oca-clabot complained, but I believe it's ok now. |
@@ -30,4 +37,4 @@ script: | |||
- travis_run_tests | |||
|
|||
after_success: | |||
coveralls | |||
- coveralls |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please put - travis_after_tests_success
:
https://github.com/OCA/maintainer-quality-tools/blob/master/sample_files/.travis.yml#L78
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replacing coveralls
, right?
👍 please make the same with 9.0 |
#82
@max3903 is this enough?
related to OCA/maintainer-quality-tools#194