[IMP] ddmrp: introduce specific security groups

Try to give a bit more of flexibility on who can modify ddmrp
master data (new ddmrp manager group) and stock buffers (new stock
stock buffer maintainer group).

ddmrp/__manifest__.py

@@ -29,9 +29,9 @@
         "data/stock_buffer_profile_data.xml",
         "data/ir_sequence.xml",
         "data/decimal_precision_data.xml",
+        "security/ddmrp_groups.xml",
+        "security/ddmrp_rules.xml",
         "security/ir.model.access.csv",
-        "security/stock_security.xml",
-        "security/stock_buffer_manual_procurement_security.xml",
         "wizards/make_procurement_buffer_view.xml",
         "views/stock_buffer_profile_view.xml",
         "views/stock_buffer_profile_variability_view.xml",
@@ -53,6 +53,7 @@
         "wizards/res_config_settings_views.xml",
     ],
     "demo": [
+        "demo/ddmrp_demo_user.xml",
         "demo/res_partner_demo.xml",
         "demo/product_category_demo.xml",
         "demo/product_product_demo.xml",

ddmrp/demo/ddmrp_demo_user.xml

@@ -0,0 +1,8 @@
+<?xml version="1.0" encoding="utf-8" ?>
+<odoo noupdate="1">
+
+    <record id="base.user_demo" model="res.users">
+        <field eval="[(4, ref('group_stock_buffer_maintainer'))]" name="groups_id" />
+    </record>
+
+</odoo>

ddmrp/security/ddmrp_groups.xml

@@ -0,0 +1,36 @@
+<?xml version="1.0" ?>
+<odoo noupdate="1">
+
+    <record id="module_category_ddmrp" model="ir.module.category">
+        <field name="name">DDMRP</field>
+        <field name="sequence">40</field>
+    </record>
+
+    <record id="group_change_buffer_procure_qty" model="res.groups">
+        <field
+            name="name"
+        >Change quantity in manual procurements from Stock Buffers</field>
+        <field name="implied_ids" eval="[(4, ref('base.group_user'))]" />
+        <field name="category_id" ref="ddmrp.module_category_ddmrp" />
+    </record>
+
+    <record id="group_stock_buffer_maintainer" model="res.groups">
+        <field name="name">Stock Buffer Maintainer</field>
+        <field name="category_id" ref="ddmrp.module_category_ddmrp" />
+        <field name="implied_ids" eval="[(4, ref('stock.group_stock_user'))]" />
+    </record>
+
+    <record id="group_ddmrp_manager" model="res.groups">
+        <field name="name">DDMRP Manager</field>
+        <field name="category_id" ref="ddmrp.module_category_ddmrp" />
+        <field
+            name="implied_ids"
+            eval="[(4, ref('ddmrp.group_stock_buffer_maintainer'))]"
+        />
+        <field
+            name="users"
+            eval="[(4, ref('base.user_root')), (4, ref('base.user_admin'))]"
+        />
+    </record>
+
+</odoo>

ddmrp/security/ir.model.access.csv

@@ -1,11 +1,11 @@
 id,name,model_id:id,group_id:id,perm_read,perm_write,perm_create,perm_unlink
 access_product_adu_calculation_method,product.adu.calculation.method,model_product_adu_calculation_method,stock.group_stock_user,1,0,0,0
-access_product_adu_calculation_method_system,product.adu.calculation.method system,model_product_adu_calculation_method,stock.group_stock_manager,1,1,1,1
+access_product_adu_calculation_method_system,product.adu.calculation.method system,model_product_adu_calculation_method,ddmrp.group_ddmrp_manager,1,1,1,1
 access_stock_buffer_profile,stock.buffer.profile,model_stock_buffer_profile,stock.group_stock_user,1,0,0,0
-access_stock_buffer_profile_system,stock.buffer.profile system,model_stock_buffer_profile,stock.group_stock_manager,1,1,1,1
+access_stock_buffer_profile_system,stock.buffer.profile system,model_stock_buffer_profile,ddmrp.group_ddmrp_manager,1,1,1,1
 access_stock_buffer_profile_lead_time,stock.buffer.profile.lead.time stock user,model_stock_buffer_profile_lead_time,stock.group_stock_user,1,0,0,0
-access_stock_buffer_profile_lead_time_manager,stock.buffer.profile.lead.time stock user,model_stock_buffer_profile_lead_time,stock.group_stock_manager,1,1,1,1
+access_stock_buffer_profile_lead_time_manager,stock.buffer.profile.lead.time stock user,model_stock_buffer_profile_lead_time,ddmrp.group_ddmrp_manager,1,1,1,1
 access_stock_buffer_profile_variability,stock.buffer.profile.variability stock user,model_stock_buffer_profile_variability,stock.group_stock_user,1,0,0,0
-access_stock_buffer_profile_variability_manager,stock.buffer.profile.variability stock manager,model_stock_buffer_profile_variability,stock.group_stock_manager,1,1,1,1
+access_stock_buffer_profile_variability_manager,stock.buffer.profile.variability stock manager,model_stock_buffer_profile_variability,ddmrp.group_ddmrp_manager,1,1,1,1
 access_stock_buffer,stock.buffer.user,model_stock_buffer,stock.group_stock_user,1,0,0,0
-access_stock_buffer_manager,stock.buffer.manager,model_stock_buffer,stock.group_stock_manager,1,1,1,1
+access_stock_buffer_manager,stock.buffer.manager,model_stock_buffer,ddmrp.group_stock_buffer_maintainer,1,1,1,1

ddmrp/tests/common.py

@@ -70,13 +70,19 @@ def setUpClass(cls):
         cls.group_change_procure_qty = cls.env.ref(
             "ddmrp.group_change_buffer_procure_qty"
         )
+        cls.group_buffer_manager = cls.env.ref("ddmrp.group_stock_buffer_maintainer")
         cls.calendar = cls.env.ref("resource.resource_calendar_std")
         cls.warehouse.calendar_id = cls.calendar
 
         # Create users
         cls.user = cls._create_user(
             "user_1",
-            [cls.group_stock_manager, cls.group_mrp_user, cls.group_change_procure_qty],
+            [
+                cls.group_stock_manager,
+                cls.group_mrp_user,
+                cls.group_change_procure_qty,
+                cls.group_buffer_manager,
+            ],
         )
         # Create Partners:
         vendor = cls.partner_model.create({"name": "Test Vendor 1"})

ddmrp/wizards/res_config_settings_views.xml

@@ -14,7 +14,7 @@
                     class="app_settings_block"
                     data-string="DDMRP"
                     data-key="ddmrp"
-                    groups="stock.group_stock_manager"
+                    groups="ddmrp.group_ddmrp_manager"
                 >
                     <h2>Extensions</h2>
                     <div class="row mt16 o_settings_container" id="ddmrp_extension">