Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.0][IMP] ddmrp_adjustment: visualize parent DAFs #423

Merged
merged 2 commits into from
Jun 12, 2024

Conversation

DavidJForgeFlow
Copy link
Contributor

Adds a button next to ADU to clearly see if the demand is being affected by a parent DAF.

@LoisRForgeFlow @ForgeFlow

@OCA-git-bot
Copy link
Contributor

Hi @JordiBForgeFlow, @LoisRForgeFlow,
some modules you are maintaining are being modified, check this out!

@DavidJForgeFlow DavidJForgeFlow force-pushed the 16.0-imp-ddmrp_adjustment branch 2 times, most recently from 0b8fab7 to 4376ec5 Compare March 25, 2024 08:54
Adds a button next to ADU to clearly see if the demand is being affected by a parent DAF.
Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When both and adjustment is directly done to a product and to the product above, the combination is not handles correclty:

image

@LoisRForgeFlow
Copy link
Contributor

@DavidJForgeFlow Interesting, in local it works fine. However there is one more detail with the displayed decimal places:

image

@LoisRForgeFlow
Copy link
Contributor

@DavidJForgeFlow Can you also take the ocassion to hide the DAF from parent smart button where there is nothing to show?

image

@DavidJForgeFlow
Copy link
Contributor Author

Hi @LoisRForgeFlow, all fixed!

Copy link
Contributor

@LoisRForgeFlow LoisRForgeFlow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@LoisRForgeFlow
Copy link
Contributor

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 16.0-ocabot-merge-pr-423-by-LoisRForgeFlow-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 67bdc59 into OCA:16.0 Jun 12, 2024
5 of 7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 70ef970. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants