Skip to content

Commit

Permalink
[FIX] delivery_roulier : get_tracking_link should return an url inste…
Browse files Browse the repository at this point in the history
…ad of a list of urls
  • Loading branch information
florian-dacosta committed Jul 9, 2024
1 parent c0191c6 commit cd1b972
Showing 1 changed file with 8 additions and 11 deletions.
19 changes: 8 additions & 11 deletions delivery_roulier/models/delivery_carrier.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,17 +37,14 @@ def cancel_shipment(self, pickings):
# is on picking. An we could have multiple urls for 1 picking, if there
# are multiple package...
# Maybe we will merge all this in future versions
def get_tracking_link(self, pickings):
if self._is_roulier():
trackings = []
for picking in pickings:
packages = picking.package_ids
first_package = packages and packages[0]
if first_package:
trackings.append(first_package._get_tracking_link())
return trackings
else:
return super().get_tracking_link(pickings)
def get_tracking_link(self, picking):
if not self._is_roulier():
return super().get_tracking_link(picking)
packages = picking.package_ids

Check warning on line 43 in delivery_roulier/models/delivery_carrier.py

View check run for this annotation

Codecov / codecov/patch

delivery_roulier/models/delivery_carrier.py#L42-L43

Added lines #L42 - L43 were not covered by tests
if not packages:
return ""
first_package = packages[0]
return first_package._get_tracking_link()

Check warning on line 47 in delivery_roulier/models/delivery_carrier.py

View check run for this annotation

Codecov / codecov/patch

delivery_roulier/models/delivery_carrier.py#L45-L47

Added lines #L45 - L47 were not covered by tests

def rate_shipment(self, order):
res = super().rate_shipment(order)
Expand Down

0 comments on commit cd1b972

Please sign in to comment.