[11.0][MIG] base_delivery_carrier_label #154

asaunier · 2018-04-11T09:33:13Z

Based upon PR #150 by @hugosantosred with a few improvements:

removed the # -*- coding: utf-8 -*- header in python files
squashed some Launchpad automatic translations update. commits and removed a Make modules uninstallable one (805b831)

I have not really been able to squash all i18n commits because the translations changes came from several origin/authors, sometimes with other changes. I have the feeling it's better to leave as is.

…ng_label

… nesting, few typos [ADD] access rights for the shipping.label model

[IMP] remove unused pdf_list variable and rename pdf variable to label as a label can have other printing format [IMP] remove readonly on carrier_tracking_ref [IMP] remove carrier_tracking_ref redefinition as already defined in delivery/stock.py [ADD] stock users rights [ADD] file type on shipping label [ADD] pot file [ADD] fr.po

…per pack (stock.tracking) [IMP] set tracking_id as an optional key of dict returned by label generation and improve doc string [IMP] rename generate_pack_labels in generate_shipping_labels as it can also generate a single label for a picking without pack notion [IMP] set labels on stock.picking instead of stock.picking.out in order to let the creation of return labels to provide to the customer [FIX] xml view and copy what is needed on stock.picking.out and stock.picking.in as it won't be inherited from stock.picking.out

[FIX] delivery.carrier has no access rights for stock users, hence remove it for delivery.carrier.option

…by raising a orm.except_orm [FIX] trigger carrier_id on change when creating a stock.picking to set default options from sale.order [IMP] change error message of unimplemented default to a more user friendly message

…te the label only for a selection of packs in a picking the button call action_generate_carrier_label() without the 'context' keyword argument so the context ends in the tracking_ids argument. So the method now conforms to the cr, uid, ids, context signature and just forwards to a new generate_labels() method that should be used from within the code do not overwrite the option_ids on create of stock.picking if already set in values, generalize the method to all types of picking (added in/out) Set the default options of the delivery method when it is changed and the options are not set (typically a write from the code or a mass update)

docstring

[FIX] action name [IMP] add descrption field to carrier option

[IMP] file_type field inheritance in shipping.label [IMP] add field selection sort

yvaucher · 2018-04-11T14:44:50Z

Great!

Just 2 more thing which could be done to improve the history of that module:

You can squash the [PEP8] commit (I don't mind if you remove my commit)
f32a2ca
into
[REF] remove stock.picking.in and .out
cae9191

you can also drop those 2 commits:
set installable to false
4b909bb

[MIG] Make modules uninstallable
28baac4

[FIX] docstring [FIX] _customize_sender_address return method [IMP] add comment in _customize_sender_adress() [FIX] method name to get sender address [FIX] method comment

move modules in __unported__

[REF] port to v8 with old api [MIG] to v8 base_deliv_label, deliv_carrier_deposit [IMP] add parcel_tracking field [IMP] add _get_packages_from_picking() add carrier_id in tree view

[FIX] complete view

Better layout of default report for deposit slip For stock.quant.package, order by id desc to have the latest first Code cleanup Button "Create Shipping Label" should be used when the picking in Done, because in v8 the packaging is handled in the "Transfer" wizard (in v7, the packaging could be made when the picking is waiting/ready) Display number of packages on deposit slip Add weight in tree view of packages

Remove an unused file 'reports.xml' Remove the selection wrappers Use the name of the method as string instead

Move module description in README.rst

Take the destination package. If empty, the package is moved so take the source one. The options must be filtered by the selected carrier

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

Because it will print several labels for the same package.

[FIX] oca remarks

add operation.get_weight() add tests fix wrong name of class refactor tests for a better readability s/tracking/package in docstring of generate_labels

- Reactivate - Move files in views and models - Adapt XML views - Update README.rst Move settings menu in Inventory/Configuration Remove test with Logistic units as it was removed from 9.0 Allow to give a filename to the created label if not defined use the attachment name Fix weight calcul adding a field for total weight This due to removed logistics units If set this field will be used to define weight, otherwise we compute weight even before quants have been created. Fix stock picking view some labels were missing and the view was scrambled Split files by model

[FIX] remove en.po that was erroneously created by transbot

Missing acl for stock user/manager

MIG 10.0 base_delivery_carrier_label

IMP modularity and fixes

* Remove manifest.wizard model access rules.

* Add an attribute for the carrier tracking URI at the `stock.quant.package` level

asaunier · 2018-04-11T15:24:03Z

@yvaucher

You can squash f32a2ca into cae9191

Well, I got some conflicts and I was not very sure how to fix them. Thus I preferred to skip squashing those ones.

you can also drop those 2 commits:

I have indeed missed 28baac4 => done

For 4b909bb set installable to false I didn't dare to drop it because it actually changes many things. If I remove it, I get a bunch of conflicts. Again I preferred to skip and avoid incorrect conflicts fixes.

On the other hand I have squashed two commits in a row by the same author on the same piece of code, which resulted in c1be3c9

simahawk · 2018-04-23T16:57:25Z

base_delivery_carrier_label/README.rst

+
+.. image:: https://odoo-community.org/website/image/ir.attachment/5784_f2813bd/datas
+   :alt: Try me on Runbot
+   :target: https://runbot.odoo-community.org/runbot/99/10.0


simahawk · 2018-04-23T16:57:41Z

base_delivery_carrier_label/__openerp__.py

+ 'category': 'Delivery',
+ 'complexity': 'normal',
+ 'depends': ['delivery'],
+ 'website': 'http://www.camptocamp.com/',


https://github.com/OCA/delivery-carrier

simahawk · 2018-04-23T16:57:48Z

base_delivery_carrier_label/__openerp__.py

+     'security/ir.model.access.csv',
+     'wizard/manifest_wizard_view.xml',
+ ],
+ 'tests': [],


simahawk · 2018-04-23T16:58:03Z

base_delivery_carrier_label/i18n/base_delivery_carrier_label.pot

@@ -0,0 +1,234 @@
+# Translation of odoo Server.


simahawk · 2018-04-26T10:53:15Z

base_delivery_carrier_label/models/carrier_account.py

+    _description = 'Base account datas'
+
+    @api.model
+    def _get_carrier_type(self):


s/selection/_get

What do you mean? Perhaps you mean _get_carrier_type should be renamed to _selection_carrier_type because it is used to feed a selection field. Is it a convention? Isn't it better to keep verb-based name for functions?

Since this method should be overridden in extended models, aren't you afraid this renaming might cause problems to inheriting modules?

simahawk · 2018-04-26T11:04:55Z

base_delivery_carrier_label/models/stock_quant_package.py

+                     ('product_id', '!=', False),
+                     ])
+
+                # we make use get_weight with  @api.muli instead of


do we need all these empty lines?

simahawk · 2018-04-26T11:05:38Z

base_delivery_carrier_label/models/stock_quant_package.py

+            elif not pack.quant_ids:
+                # package.pack_operations would be too easy
+                operations = self.env['stock.move.line'].search(
+                    [('result_package_id', '=', pack.id),


.search([ ('result_package_id', '=', pack.id), ('product_id', '!=', False), ])

simahawk · 2018-04-26T11:06:06Z

base_delivery_carrier_label/models/stock_quant_package.py

+
+    @api.multi
+    def _complete_name(self, name, args):
+        res = super(StockQuantPackage, self)._complete_name(name, args)


all the super calls can be done w/out args on py3 super().foo()

simahawk · 2018-04-26T11:07:43Z

base_delivery_carrier_label/wizard/manifest_wizard.py

+    _description = 'Delivery carrier manifest wizard'
+
+    @api.model
+    def _get_carrier_type_selection(self):


simahawk · 2018-04-26T11:08:16Z

base_delivery_carrier_label/wizard/manifest_wizard.py

+
+    @api.one
+    def get_manifest_file(self):
+        raise exceptions.Warning(_("Manifest not implemented for '%s' "


NotImplementedError

asaunier · 2018-05-02T11:48:22Z

@simahawk Thanks for reviewing! I have made the changes you have suggested, see 49bfef9

simahawk

LGTM

asaunier · 2018-05-02T15:40:31Z

I have squashed my commits. PR is ready for merging if no other objection is raised.

yvaucher and others added 15 commits January 17, 2018 13:13

[ADD] base_delivery_carrier_label portage of Akretion delivery_shippi…

f22faf1

…ng_label

[CHG] pep-8 and pep-257, return eagerly in option_ids_change to avoid…

ec617c5

… nesting, few typos [ADD] access rights for the shipping.label model

[DEL] Remove unused views

a9422b0

[FIX] load the ir.model.access.csv file

0602335

[FIX] delivery.carrier has no access rights for stock users, hence remove it for delivery.carrier.option

[IMP] add a menu entry 'Carriers' in settings

a84e4c4

base_delivery_carrier_label - Improve carrier type selection inheritance

2125fff

docstring

Launchpad automatic translations update.

b07169a

[IMP] add common view action to use by module install

d589b6f

[FIX] action name [IMP] add descrption field to carrier option

When tracking_ids is defined, generate one default label per tracking id

299be25

[IMP] complete translation and fix view

7279060

[IMP] file_type field inheritance in shipping.label [IMP] add field selection sort

Launchpad automatic translations update.

c67ddf1

asaunier mentioned this pull request Apr 11, 2018

[11.0] Migrate base_delivery_carrier_label #150

Closed

pedrobaeza added this to the 11.0 milestone Apr 11, 2018

pedrobaeza added the needs review label Apr 11, 2018

pedrobaeza mentioned this pull request Apr 11, 2018

Migration to version 11.0 #139

Closed

19 tasks

bealdav and others added 10 commits April 11, 2018 17:16

[IMP] add _customize_sender_address method

c1be3c9

[FIX] docstring [FIX] _customize_sender_address return method [IMP] add comment in _customize_sender_adress() [FIX] method name to get sender address [FIX] method comment

set installable to false

4d34fa4

move modules in __unported__

[REF] remove stock.picking.in and .out

2875b2d

[REF] port to v8 with old api [MIG] to v8 base_deliv_label, deliv_carrier_deposit [IMP] add parcel_tracking field [IMP] add _get_packages_from_picking() add carrier_id in tree view

[FIX] add explicitely attachment_id (previously included by orm)

b87ae5b

[FIX] complete view

[FIX] weight field type

cd2a811

Migrate to new API

5f01afc

Remove an unused file 'reports.xml' Remove the selection wrappers Use the name of the method as string instead

Remove _order on stock.quant.packages, as asked by Guewen

b374c71

[FIX] writing package_id field in shipping.label

ff67509

[Usability] Better name_get on stock.quant.package

a0a1736

Move module description in README.rst

guewen and others added 21 commits April 11, 2018 17:16

Allow to generate labels when we moved an entire package

810ad23

Take the destination package. If empty, the package is moved so take the source one. The options must be filtered by the selected carrier

Add OCA as author of OCA addons

c1f54e9

In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.

[PEP8]

dedf3e1

add and generate initial german translations

be0ca33

[NEW] Added spanish translation

3c001f8

Do not return duplicate packages when several moves have the same one

361c9bf

Because it will print several labels for the same package.

[UPD] prefix versions with 8.0

31ea726

[IMP] add get_weight() to quant package

14e4c94

[IMP] put set_pack_weight() in picking

a680293

[IMP] put _check_existing_shipping_label() in picking

e7bac7c

[FIX] oca remarks

refactore stock.get_weight()

613c95e

add operation.get_weight() add tests fix wrong name of class refactor tests for a better readability s/tracking/package in docstring of generate_labels

OCA Transbot updated translations from Transifex

071e5c4

[FIX] remove en.po that was erroneously created by transbot

Rename field type to carrier_type in delivery.carrier

e599c98

Missing acl for stock user/manager

WIP migraciont label

fca2aec

MIG 10.0 base_delivery_carrier_label

ADD manifest and MIG 10

f0ce9e4

FIX manifest wizard as transient model

790c159

IMP modularity and fixes

Use correct syntax to add options with onchange on stock picking

343865e

[FIX] base_delivery_carrier_label: Fix security.

98eed45

* Remove manifest.wizard model access rules.

[IMP] base_delivery_carrier_label: Add quant package tracking URI

1658a6a

* Add an attribute for the carrier tracking URI at the `stock.quant.package` level

[MIG] 11.0 base_delivery_carrier_label

bc132a3

simahawk requested changes Apr 26, 2018

View reviewed changes

simahawk approved these changes May 2, 2018

View reviewed changes

[IMP] Improve migration to 11.0

4801843

gurneyalex approved these changes May 29, 2018

View reviewed changes

gurneyalex merged commit ccc5e4b into OCA:11.0 May 29, 2018

asaunier deleted the 11.0-mig-base_delivery_carrier_label branch May 29, 2018 08:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][MIG] base_delivery_carrier_label #154

[11.0][MIG] base_delivery_carrier_label #154

asaunier commented Apr 11, 2018

yvaucher commented Apr 11, 2018

asaunier commented Apr 11, 2018 •

edited

Loading

simahawk Apr 23, 2018

simahawk Apr 23, 2018

simahawk Apr 23, 2018

simahawk Apr 23, 2018

simahawk Apr 26, 2018

asaunier Apr 27, 2018 •

edited

Loading

simahawk Apr 26, 2018

simahawk Apr 26, 2018

simahawk Apr 26, 2018

simahawk Apr 26, 2018

simahawk Apr 26, 2018

asaunier commented May 2, 2018

simahawk left a comment

asaunier commented May 2, 2018 •

edited

Loading

[11.0][MIG] base_delivery_carrier_label #154

[11.0][MIG] base_delivery_carrier_label #154

Conversation

asaunier commented Apr 11, 2018

yvaucher commented Apr 11, 2018

asaunier commented Apr 11, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asaunier Apr 27, 2018 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

asaunier commented May 2, 2018

simahawk left a comment

Choose a reason for hiding this comment

asaunier commented May 2, 2018 • edited Loading

asaunier commented Apr 11, 2018 •

edited

Loading

asaunier Apr 27, 2018 •

edited

Loading

asaunier commented May 2, 2018 •

edited

Loading