[11.0][NEW] partner_delivery_zone: New module to group partners, orders and pickings by delivery zones #167

sergio-teruel · 2018-10-18T07:54:22Z

rousseldenis · 2018-10-18T08:02:26Z

partner_delivery_zone/models/res_partner.py

+    )
+
+    @api.model
+    def _commercial_fields(self):


@sergio-teruel Really? This could be too restrictive as it forbids to have a company with several delivery zones.

Uuuupss!!! You are right

You can still provide a default when creating the contacts.

sergio-teruel · 2018-10-18T08:11:41Z

@rousseldenis Changes done, also update the test

rousseldenis

Code review.

@sergio-teruel Could the 'zone' be generalized ? It could be nice to have a general defintion of it. And then reuse it on some interesting functional points (like sale zones, or ... and add after that a geoengine layer).

rousseldenis · 2018-10-18T08:27:52Z

@sergio-teruel pylint and flake8 fail

pedrobaeza · 2018-10-18T11:13:25Z

@rousseldenis unfortunately we don't have budget for more changes, as this being very small (the model has 2 fields), it can be extracted or replicated easily if someone has that need to put this on other place without depending on this module.

@sergio-teruel, little flake8 fail:

partner_delivery_zone/models/res_partner.py:3:1: F401 'odoo.api' imported but unused

I'm reviewing code now.

pedrobaeza · 2018-10-18T11:16:20Z

partner_delivery_zone/models/sale_order.py

+
+    @api.onchange('partner_shipping_id')
+    def onchange_partner_shipping_id_delivery_zone(self):
+        self.delivery_zone_id = self.partner_shipping_id.delivery_zone_id.id


Only change this if the partner has a delivery zone set. If not, preserve the previous value.

pedrobaeza · 2018-10-18T11:16:55Z

partner_delivery_zone/models/stock_picking.py

+
+    @api.onchange('partner_id')
+    def onchange_partner_id_zone(self):
+        self.delivery_zone_id = self.partner_id.delivery_zone_id


The same about preserving previous value

pedrobaeza · 2018-10-18T11:17:34Z

partner_delivery_zone/readme/DESCRIPTION.rst

@@ -0,0 +1,4 @@
+This module allows set delivery zones on partner, this information is written


s/allow set/allows to set.

Put a . instead of comma before this information...

pedrobaeza · 2018-10-18T11:18:09Z

partner_delivery_zone/readme/DESCRIPTION.rst

@@ -0,0 +1,4 @@
+This module allows set delivery zones on partner, this information is written
+in sale orders and stock pickings.
+Also adds searchs and groups in partners, sales orders asn stock pickings


s/Also/It also
s/searchs/searches
s/asn/and

pedrobaeza · 2018-10-18T11:18:33Z

partner_delivery_zone/readme/ROADMAP.rst

@@ -0,0 +1,2 @@
+* For a future, the system will can set delivery zones based on partner zip.


s/a/the
s/the system/system
s/will can/can

pedrobaeza · 2018-10-18T11:19:03Z

partner_delivery_zone/readme/ROADMAP.rst

@@ -0,0 +1,2 @@
+* For a future, the system will can set delivery zones based on partner zip.
+  I will create a rules for that.


Remove this sentence

pedrobaeza · 2018-10-18T11:19:59Z

partner_delivery_zone/readme/USAGE.rst

@@ -0,0 +1,9 @@
+To use this module you need to:
+
+#. Go to *Contacts > Create* or *Sales > Customers > Create*.


Put second part of this sentence as a new point before "Create a sales order..."

pedrobaeza · 2018-10-18T11:24:34Z

partner_delivery_zone/views/res_partner_view.xml

+        <field name="inherit_id" ref="base.view_partner_form"/>
+        <field name="arch" type="xml">
+            <field name="industry_id" position="after">
+                <field name="delivery_zone_id"/>


Delivery zone is not shown nor put as default for children contacts managed from the same view.

partner_delivery_zone/tests/test_partner_delivery_zone.py

…rs and pickings by delivery zones

sergio-teruel · 2018-10-20T22:10:17Z

@rousseldenis @pedrobaeza Changes done!.
Added default delivery zone for child_ids field in context and fix typo and form view for contacts

pedrobaeza

Thanks for the changes. Next time please put a new fixup commit instead of amending previous one, as this way it's very difficult to review latest changes.

sergio-teruel · 2018-10-21T06:22:54Z

Oks. Thanks

rousseldenis added the needs review label Oct 18, 2018

rousseldenis added this to the 11.0 milestone Oct 18, 2018

rousseldenis reviewed Oct 18, 2018

View reviewed changes

sergio-teruel force-pushed the 11.0-PR-partner_delivery_zone branch from 73a0360 to a0f648e Compare October 18, 2018 08:11

rousseldenis approved these changes Oct 18, 2018

View reviewed changes

pedrobaeza requested changes Oct 18, 2018

View reviewed changes

rousseldenis reviewed Oct 18, 2018

View reviewed changes

partner_delivery_zone/tests/test_partner_delivery_zone.py Show resolved Hide resolved

rousseldenis mentioned this pull request Oct 18, 2018

Running tests on post_install OCA/odoo-community.org#28

Open

sergio-teruel force-pushed the 11.0-PR-partner_delivery_zone branch from a0f648e to 91f8349 Compare October 20, 2018 21:59

[11.0][NEW] partner_delivery_zone: New module to group partners, orde…

6178cc4

…rs and pickings by delivery zones

sergio-teruel force-pushed the 11.0-PR-partner_delivery_zone branch from 91f8349 to 6178cc4 Compare October 20, 2018 22:08

pedrobaeza approved these changes Oct 20, 2018

View reviewed changes

rousseldenis merged commit 0a53983 into OCA:11.0 Oct 23, 2018

sergio-teruel deleted the 11.0-PR-partner_delivery_zone branch January 18, 2019 15:37

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[11.0][NEW] partner_delivery_zone: New module to group partners, orders and pickings by delivery zones #167

[11.0][NEW] partner_delivery_zone: New module to group partners, orders and pickings by delivery zones #167

sergio-teruel commented Oct 18, 2018

rousseldenis Oct 18, 2018

sergio-teruel Oct 18, 2018

pedrobaeza Oct 18, 2018

sergio-teruel commented Oct 18, 2018

rousseldenis left a comment

rousseldenis commented Oct 18, 2018

pedrobaeza commented Oct 18, 2018

pedrobaeza Oct 18, 2018

pedrobaeza Oct 18, 2018

pedrobaeza Oct 18, 2018

pedrobaeza Oct 18, 2018

pedrobaeza Oct 18, 2018

pedrobaeza Oct 18, 2018

pedrobaeza Oct 18, 2018

pedrobaeza Oct 18, 2018

sergio-teruel commented Oct 20, 2018

pedrobaeza left a comment

sergio-teruel commented Oct 21, 2018

		@@ -0,0 +1,4 @@
		This module allows set delivery zones on partner, this information is written

		@@ -0,0 +1,2 @@
		* For a future, the system will can set delivery zones based on partner zip.

		@@ -0,0 +1,2 @@
		* For a future, the system will can set delivery zones based on partner zip.
		I will create a rules for that.

		@@ -0,0 +1,9 @@
		To use this module you need to:

		#. Go to Contacts > Create or Sales > Customers > Create.

[11.0][NEW] partner_delivery_zone: New module to group partners, orders and pickings by delivery zones #167

[11.0][NEW] partner_delivery_zone: New module to group partners, orders and pickings by delivery zones #167

Conversation

sergio-teruel commented Oct 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergio-teruel commented Oct 18, 2018

rousseldenis left a comment

Choose a reason for hiding this comment

rousseldenis commented Oct 18, 2018

pedrobaeza commented Oct 18, 2018

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sergio-teruel commented Oct 20, 2018

pedrobaeza left a comment

Choose a reason for hiding this comment

sergio-teruel commented Oct 21, 2018