[12.0][MIG] base_delivery_carrier_label #187
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… nesting, few typos [ADD] access rights for the shipping.label model
[IMP] remove unused pdf_list variable and rename pdf variable to label as a label can have other printing format [IMP] remove readonly on carrier_tracking_ref [IMP] remove carrier_tracking_ref redefinition as already defined in delivery/stock.py [ADD] stock users rights [ADD] file type on shipping label [ADD] pot file [ADD] fr.po
…per pack (stock.tracking) [IMP] set tracking_id as an optional key of dict returned by label generation and improve doc string [IMP] rename generate_pack_labels in generate_shipping_labels as it can also generate a single label for a picking without pack notion [IMP] set labels on stock.picking instead of stock.picking.out in order to let the creation of return labels to provide to the customer [FIX] xml view and copy what is needed on stock.picking.out and stock.picking.in as it won't be inherited from stock.picking.out
[FIX] delivery.carrier has no access rights for stock users, hence remove it for delivery.carrier.option
…by raising a orm.except_orm [FIX] trigger carrier_id on change when creating a stock.picking to set default options from sale.order [IMP] change error message of unimplemented default to a more user friendly message
…te the label only for a selection of packs in a picking the button call action_generate_carrier_label() without the 'context' keyword argument so the context ends in the tracking_ids argument. So the method now conforms to the cr, uid, ids, context signature and just forwards to a new generate_labels() method that should be used from within the code do not overwrite the option_ids on create of stock.picking if already set in values, generalize the method to all types of picking (added in/out) Set the default options of the delivery method when it is changed and the options are not set (typically a write from the code or a mass update)
[FIX] action name [IMP] add descrption field to carrier option
[IMP] file_type field inheritance in shipping.label [IMP] add field selection sort
[FIX] docstring [FIX] _customize_sender_address return method [IMP] add comment in _customize_sender_adress() [FIX] method name to get sender address [FIX] method comment
move modules in __unported__
[REF] port to v8 with old api [MIG] to v8 base_deliv_label, deliv_carrier_deposit [IMP] add parcel_tracking field [IMP] add _get_packages_from_picking() add carrier_id in tree view
[FIX] complete view
Better layout of default report for deposit slip For stock.quant.package, order by id desc to have the latest first Code cleanup Button "Create Shipping Label" should be used when the picking in Done, because in v8 the packaging is handled in the "Transfer" wizard (in v7, the packaging could be made when the picking is waiting/ready) Display number of packages on deposit slip Add weight in tree view of packages
Remove an unused file 'reports.xml' Remove the selection wrappers Use the name of the method as string instead
Move module description in README.rst
Take the destination package. If empty, the package is moved so take the source one. The options must be filtered by the selected carrier
In order to get visibility on https://www.odoo.com/apps the OCA board has decided to add the OCA as author of all the addons maintained as part of the association.
IMP modularity and fixes
* Remove manifest.wizard model access rules.
* Add an attribute for the carrier tracking URI at the `stock.quant.package` level
Field carrier_type was originally type and was used to differentiate delivery carriers. However odoo did implement delivery_type since v9 with this exact goal : https://github.com/odoo/odoo/blob/11.0/addons/delivery/models/delivery_carrier.py#L22 This is also the field used in the implementation of enterprise modules for carriers. Therefore we should use it instead of redefining a new one..
|
Hey @Timo17100-c2c, thank you for your Pull Request. It looks like some users haven't signed our Contributor License Agreement, yet.
Appreciation of efforts, |
13 tasks
yvaucher
reviewed
May 9, 2019
| ('product_id', '!=', False), | ||
| ]) | ||
|
|
||
| # we make use get_weight with @api.muli instead of |
There was a problem hiding this comment.
This comment was probably already there, let's fix it.
Suggested change
| # we make use get_weight with @api.muli instead of | |
| # we make use get_weight with @api.multi instead of |
yvaucher
reviewed
May 9, 2019
| * Alexis de Lattre <alexis.delattre@akretion.com> | ||
| * Angel Moya <angel.moya@pesol.es> | ||
| * Ismael Calvo <ismael.calvo@factorlibre.com> | ||
| * Dave Lasley <dave@laslabs.com> |
There was a problem hiding this comment.
Don't forget to add your name at the end.
|
Please merge commits like |
|
False positive error
|
@bealdav Nope. testing is ok. But build failed because there are two WARNING lines. |
Timo17100-c2c
force-pushed
the
12.0-mig-base_delivery_carrier_label
branch
from
5144d80
to
f0f4029
Compare
|
Hey @Timo17100-c2c, Appreciation of efforts, |
|
Hi @Timo17100-c2c , we are in OCA Sprintcode working on this repo, there would be nice if you can check comments this days, thanks a lot |
|
Check #199 , we think that migration to version 11.0 was not right |
|
Please consider this PR Timo17100-c2c#1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.