-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ADD] delivery_price_rule_untaxed #474
[ADD] delivery_price_rule_untaxed #474
Conversation
Currently translated at 100.0% (4 of 4 strings) Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_price_rule_untaxed Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_price_rule_untaxed/it/
/ocabot migration delivery_price_rule_untaxed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Some minor changes.
"version": "14.0.1.0.0", | ||
"development_status": "Beta", | ||
"category": "Stock", | ||
"website": "https://github.com/OCA/delivery-carrier" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"website": "https://github.com/OCA/delivery-carrier" | |
"website": "https://github.com/OCA/delivery-carrier/tree/" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have tried to update the website, but hook id: oca-fix-manifest-website is removing the '/tree/' from the URL. Suggest the solution or alternative way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just change to https://github.com/OCA/delivery-carrier
delivery_price_rule_untaxed/data/delivery_price_rule_untaxed_demo.xml
Outdated
Show resolved
Hide resolved
delivery_price_rule_untaxed/tests/test_delivery_price_rule_untaxed.py
Outdated
Show resolved
Hide resolved
8e5a4e4
to
3e20c85
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@rousseldenis merge? |
/ocabot merge patch |
What a great day to merge this nice PR. Let's do it! |
Congratulations, your PR was merged at f5db704. Thanks a lot for contributing to OCA. ❤️ |
migration to 14.0