Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADD] delivery_price_rule_untaxed #474

Merged

Conversation

AshishHirapara
Copy link

migration to 14.0

@AshishHirapara AshishHirapara mentioned this pull request Apr 11, 2022
21 tasks
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration delivery_price_rule_untaxed

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Some minor changes.

"version": "14.0.1.0.0",
"development_status": "Beta",
"category": "Stock",
"website": "https://github.com/OCA/delivery-carrier"
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"website": "https://github.com/OCA/delivery-carrier"
"website": "https://github.com/OCA/delivery-carrier/tree/"

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tried to update the website, but hook id: oca-fix-manifest-website is removing the '/tree/' from the URL. Suggest the solution or alternative way.

Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

delivery_price_rule_untaxed/__manifest__.py Outdated Show resolved Hide resolved
delivery_price_rule_untaxed/__manifest__.py Outdated Show resolved Hide resolved
@AshishHirapara AshishHirapara force-pushed the 14.0-mig-delivery_price_rule_untaxed branch from 8e5a4e4 to 3e20c85 Compare April 13, 2022 14:20
Copy link
Contributor

@francesco-ooops francesco-ooops left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link

@elvise elvise left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@francesco-ooops
Copy link
Contributor

@rousseldenis merge?

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 14.0-ocabot-merge-pr-474-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 15ad710 into OCA:14.0 Apr 13, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f5db704. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants