Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[15.0][MIG] stock_picking_delivery_link #532

Merged
merged 9 commits into from
Oct 10, 2022
Merged

[15.0][MIG] stock_picking_delivery_link #532

merged 9 commits into from
Oct 10, 2022

Conversation

flachica
Copy link
Contributor

No description provided.

@flachica flachica mentioned this pull request Sep 28, 2022
Open
31 tasks
victoralmau
victoralmau suggested changes Sep 29, 2022
View reviewed changes
stock_picking_delivery_link/tests/common.py Outdated Show resolved Hide resolved
stock_picking_delivery_link/tests/common.py Outdated Show resolved Hide resolved
@flachica flachica force-pushed the 15.0-mig-stock_picking_delivery_link branch from d4f9594 to 8cf6de0 Compare September 29, 2022 10:28
@flachica
Copy link
Contributor Author

Thanks @victoralmau I was distracted. I am doing a migration of a module with many dependencies and I am gradually checking

victoralmau
victoralmau approved these changes Sep 29, 2022
View reviewed changes
Copy link
Member

@victoralmau victoralmau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK (although I have never used this module).

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration stock_picking_delivery_link

@OCA-git-bot OCA-git-bot added this to the 15.0 milestone Oct 10, 2022
rousseldenis
rousseldenis approved these changes Oct 10, 2022
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 15.0-ocabot-merge-pr-532-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 19387a3 into OCA:15.0 Oct 10, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 3c13aed. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@victoralmau victoralmau victoralmau approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
15.0
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@flachica @rousseldenis @OCA-git-bot @victoralmau @sebalix @oca-travis @hparfr