-
-
Notifications
You must be signed in to change notification settings - Fork 341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[15.0][MIG] delivery_price_method: Migration to 15.0 #536
[15.0][MIG] delivery_price_method: Migration to 15.0 #536
Conversation
8904e39
to
184cdd7
Compare
/ocabot migration delivery_price_method |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code review
- Add default price_method called "Carrier obtained price", for being more explicit and avoid user confusions. - Shipment rate: Make it compatible with upstream code tricking the delivery_type field. - Shipping sending: Call upstream carrier sending routine + call standard one, and merge results (excluding the tracking_number). - Tests: * Make them more resilient (fixing the pricelist). * Use SavepointCase for executing setup only once. * Fine tune some code - Improve README [UPD] Update delivery_price_method.pot
[UPD] Update delivery_price_method.pot [UPD] README.rst
If a user don't have the necessary permissions for writing in the `delivery.carrier` model (like a low range salesman) he won't be able to choose a carrier wich uses the rate shipment override. TT31627 delivery_price_method 13.0.1.0.1
[UPD] README.rst delivery_price_method 13.0.1.0.2
Currently translated at 100.0% (6 of 6 strings) Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_price_method Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_price_method/es/
Currently translated at 100.0% (6 of 6 strings) Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_price_method Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_price_method/es_CL/
TT36947 [UPD] Update delivery_price_method.pot [UPD] README.rst
184cdd7
to
c9deea9
Compare
TT36947 Co-authored-by: jaredkipe
c9deea9
to
18953fb
Compare
Changes done. |
/ocabot merge nobump |
This PR looks fantastic, let's merge it! |
Congratulations, your PR was merged at f6375ff. Thanks a lot for contributing to OCA. ❤️ |
Superseed #524
Migration to 15.0
Please @pedrobaeza and @chienandalu can you review it?
@Tecnativa TT36947