Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[15.0][MIG] delivery_price_method: Migration to 15.0 #536

Merged
merged 16 commits into from
Oct 11, 2022

Conversation

victoralmau
Copy link
Member

Superseed #524

Migration to 15.0

Please @pedrobaeza and @chienandalu can you review it?

@Tecnativa TT36947

@victoralmau victoralmau force-pushed the 15.0-mig-delivery_price_method branch 2 times, most recently from 8904e39 to 184cdd7 Compare October 6, 2022 07:45
@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration delivery_price_method

Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review

rlizana and others added 14 commits October 11, 2022 09:45
- Add default price_method called "Carrier obtained price", for being more explicit
  and avoid user confusions.
- Shipment rate: Make it compatible with upstream code tricking the delivery_type
  field.
- Shipping sending: Call upstream carrier sending routine + call standard one, and
  merge results (excluding the tracking_number).
- Tests:

  * Make them more resilient (fixing the pricelist).
  * Use SavepointCase for executing setup only once.
  * Fine tune some code
- Improve README

[UPD] Update delivery_price_method.pot
[UPD] Update delivery_price_method.pot

[UPD] README.rst
If a user don't have the necessary permissions for writing in the
`delivery.carrier` model (like a low range salesman) he won't be able to
choose a carrier wich uses the rate shipment override.

TT31627

delivery_price_method 13.0.1.0.1
[UPD] README.rst

delivery_price_method 13.0.1.0.2
Currently translated at 100.0% (6 of 6 strings)

Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_price_method
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_price_method/es/
Currently translated at 100.0% (6 of 6 strings)

Translation: delivery-carrier-13.0/delivery-carrier-13.0-delivery_price_method
Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-13-0/delivery-carrier-13-0-delivery_price_method/es_CL/
TT36947

[UPD] Update delivery_price_method.pot

[UPD] README.rst
@victoralmau
Copy link
Member Author

Changes done.

@pedrobaeza
Copy link
Member

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 15.0-ocabot-merge-pr-536-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 02d4b6d into OCA:15.0 Oct 11, 2022
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f6375ff. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants