Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0][MIG] stock_picking_delivery_link #596

Merged
merged 14 commits into from
Jan 18, 2023
Merged

[16.0][MIG] stock_picking_delivery_link #596

merged 14 commits into from
Jan 18, 2023

Conversation

glitchov
Copy link
Contributor

@glitchov glitchov commented Jan 9, 2023

migration from 15

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration stock_picking_delivery_link

rousseldenis
rousseldenis approved these changes Jan 10, 2023
View reviewed changes
Copy link
Sponsor Contributor

@rousseldenis rousseldenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Code review

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 10, 2023
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 10, 2023
Open
31 tasks
@glitchov glitchov force-pushed the 16.0-mig-stock_picking_delivery_link-hda branch from ecbebae to 54fe0cd Compare January 10, 2023 09:35
lmignon
lmignon approved these changes Jan 11, 2023
View reviewed changes
Copy link
Sponsor

@lmignon lmignon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @glitchov LGTM (Code review + functional tests)

@OCA-git-bot
Copy link
Contributor

This PR has the approved label and has been created more than 5 days ago. It should therefore be ready to merge by a maintainer (or a PSC member if the concerned addon has no declared maintainer). 🤖

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge patch

@OCA-git-bot
Copy link
Contributor

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-596-by-rousseldenis-bump-patch, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 4c5eb6a into OCA:16.0 Jan 18, 2023
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 9f11ef2. Thanks a lot for contributing to OCA. ❤️

@FrancoMaxime FrancoMaxime deleted the 16.0-mig-stock_picking_delivery_link-hda branch January 19, 2023 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lmignon lmignon lmignon approved these changes

@jbaudoux jbaudoux jbaudoux approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review ready to merge
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet
9 participants
@glitchov @rousseldenis @OCA-git-bot @lmignon @jbaudoux @sebalix @oca-travis @hparfr @flachica