[MIG] delivery_multi_destination: Migration to 16.0 #631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GabbasovDinar
force-pushed
the
t2457-16.0-delivery_multi_destination
branch
from
8f48b8a
to
ee9a8d1
Compare
|
Please, cherry-pick #636 to commit history |
GabbasovDinar
force-pushed
the
t2457-16.0-delivery_multi_destination
branch
2 times, most recently
from
90d1a67
to
29d7634
Compare
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
|
@GabbasovDinar can you cherry-pick latest commits to complete this and merge it if everything OK? |
github-actions
bot
removed
the
stale
|
Hi @GabbasovDinar and thanks for PR. |
GabbasovDinar
force-pushed
the
t2457-16.0-delivery_multi_destination
branch
from
29d7634
to
f9986d8
Compare
|
Hello @pedrobaeza I apologize for the delay on this PR, I've moved all the remaining commits over |
================================================== Multiple destinations for the same delivery method ================================================== Module `delivery` in version 8 allows to set different price rules depending on the destination. This is what is called a delivery grid. In version 9, for simplifying delivery methods, Odoo has plained the structure, lowering destinations at delivery method level, and removing delivery grid model. This is not usable when you have different prices according the destination of your delivery. This module restores the same concept, reusing the same model for nesting several "children" delivery methods, one per possible destination. It has been designed to reuse all possible extensions to the base delivery, without the need to create a glue module for having multiple destinations. This module also handles if you're migrating from version 8 and you had `delivery` module installed, to keep the delivery grids. Installation ============ If you installed the module on a version 8 migrated database, some operations will be done for recovering delivery grids. If so, you need to have **openupgradelib** library installed. Configuration ============= To configure delivery methods with multiple destinations: * Go to Inventory > Configuration > Delivery > Delivery Methods * Create or edit an existing record. * Select "Destination type" = "Multiple destinations". * Introduce a line for each destination in the new tab "Destinations" * Lines have priority, so you have to put first the lines with more restricted destinations. Usage ===== * When using the delivery method in a Sales order, delivery address will be used for computing the delivery price according introduced destinations.
OCA Transbot updated translations from Transifex
…#148) * Don't show children carriers on many2one selections * Don't search by default children carriers * Add demo data OCA Transbot updated translations from Transifex
* Standard procedure * README by fragments * Code changed to follow v11 logic * Tests adapted and expanded
Incorrect use of variables
Currently translated at 100.0% (16 of 16 strings) Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_multi_destination Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_multi_destination/zh_CN/
Currently translated at 100.0% (16 of 16 strings) Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_multi_destination Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_multi_destination/pt_BR/
Currently translated at 56.2% (9 of 16 strings) Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_multi_destination Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_multi_destination/de/
…lements On a multi-destination carrier, that fields shouldn't be shown
…main one When testing available carriers, we must return the main one if one of the children matches, not returning the children itself.
…h multi Handle the step of sending the shipping (triggered on picking validation) for multi destination delivery. This means to manually check for fixing prices (as the implementation doesn't check this part and always take the main carrier price, not the subcarrier one. Test for this use case done, although the rest of the cases are not covered by tests yet.
Currently translated at 5.9% (1 of 17 strings) Translation: delivery-carrier-12.0/delivery-carrier-12.0-delivery_multi_destination Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-12-0/delivery-carrier-12-0-delivery_multi_destination/sl/
[UPD] Update delivery_multi_destination.pot [UPD] README.rst
[UPD] Update delivery_multi_destination.pot [UPD] README.rst
Currently translated at 100.0% (17 of 17 strings) Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_multi_destination Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_multi_destination/pt_BR/
When there is no carrier, destination_type is false and can cause error. In the case, `one` destination_type should be used. delivery_multi_destination 14.0.1.0.1
Currently translated at 47.0% (8 of 17 strings) Translation: delivery-carrier-14.0/delivery-carrier-14.0-delivery_multi_destination Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-14-0/delivery-carrier-14-0-delivery_multi_destination/es/
Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: delivery-carrier-15.0/delivery-carrier-15.0-delivery_multi_destination Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-15-0/delivery-carrier-15-0-delivery_multi_destination/
…le carrier with UX TT42837
This reverts commit 0e28544. This ismixing in the same commit other things for a non related problem that has been fixed in a better way in the previous version, so we are reverting it and applying the rest of the patches.
…sed on rules If the destination carrier line is based on rules, the price is not correctly fetched, as it's hardcoded to call `_get_price_available` using picking's carrier, no matter the recordset from which you call it (the self argument). Thus, the only solution to get the proper value is to temporarily replace the carrier on the picking on the calls chain, to restore it before returning. TT42862
… other companies In the context where `carrier.child_ids` is being examined, all existing subdestinations, no matter the company they have, are shown as being in a sudo environment, so we need to filter them out those from other companies. TT43596
Currently translated at 100.0% (16 of 16 strings) Translation: delivery-carrier-15.0/delivery-carrier-15.0-delivery_multi_destination Translate-URL: https://translation.odoo-community.org/projects/delivery-carrier-15-0/delivery-carrier-15-0-delivery_multi_destination/es/
GabbasovDinar
force-pushed
the
t2457-16.0-delivery_multi_destination
branch
from
f9986d8
to
bdb4d3c
Compare
|
Please check CI. |
|
Hi, could you please rebase? i have checked on my local your changes and works correctly. |
|
@GabbasovDinar Do you mind if we switch to #766 ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.