-
-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[16.0] [MIG] delivery_dropoff_site #754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
thanks :) |
/ocabot migration delivery_dropoff_site |
hello, Thanks you for your job. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
functionnal test OK on ruboat
): | ||
self.partner_shipping_id = False | ||
if carrier and carrier.with_dropoff_site: | ||
return { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jdoutreloux Returning domains is deprecated. Could you find another solution ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@rousseldenis fixed it. Thanks for the catch :)
da49e6d
to
4dcc641
Compare
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
Hi @jdoutreloux |
…ng_id (sale order)
Adaptation for rename odoo groups and views, rename file to correspond to the model and add migration script
4dcc641
to
9e53b66
Compare
Done |
/ocabot merge nobump |
On my way to merge this fine PR! |
Congratulations, your PR was merged at e892f9a. Thanks a lot for contributing to OCA. ❤️ |
Thanks for the rebase @ThomasBinsfeld |
Based on #504