Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[16.0] [MIG] delivery_dropoff_site #754

Merged
merged 15 commits into from
Jul 1, 2024
Merged

[16.0] [MIG] delivery_dropoff_site #754

merged 15 commits into from
Jul 1, 2024

Conversation

jdoutreloux
Copy link
Contributor

Based on #504

@ThomasBinsfeld ThomasBinsfeld mentioned this pull request Jan 5, 2024
Closed
DorianMAG
DorianMAG approved these changes Jan 5, 2024
View reviewed changes
Copy link

@DorianMAG DorianMAG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@jdoutreloux
Copy link
Contributor Author

Thx for this work, lgtm !

thanks :)

@rousseldenis
Copy link
Sponsor Contributor

/ocabot migration delivery_dropoff_site

@OCA-git-bot OCA-git-bot added this to the 16.0 milestone Jan 8, 2024
@OCA-git-bot OCA-git-bot mentioned this pull request Jan 8, 2024
Open
31 tasks
@gaelTorrecillas
Copy link
Contributor

hello,

Thanks you for your job.

flotho
flotho approved these changes Jan 10, 2024
View reviewed changes
Copy link
Member

@flotho flotho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

functionnal test OK on ruboat

rousseldenis
rousseldenis reviewed Feb 17, 2024
View reviewed changes
delivery_dropoff_site/models/sale_order.py Outdated
):
self.partner_shipping_id = False
if carrier and carrier.with_dropoff_site:
return {
Copy link
Sponsor Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jdoutreloux Returning domains is deprecated. Could you find another solution ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rousseldenis fixed it. Thanks for the catch :)

@github-actions GitHub Actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Jun 30, 2024
@DorianMAG
Copy link

Hi @jdoutreloux
Can you rebase plz?

@jdoutreloux @ThomasBinsfeld
[MIG] delivery_dropoff_site: Migration to 16.0
bc25dbf
@jdoutreloux @ThomasBinsfeld
[IMP] web_widget_ck_editor: fix pre-commit
181353d
@jdoutreloux @ThomasBinsfeld
[MIG] delivery_dropoff_site: migration to v16
9e53b66 
Adaptation for rename odoo groups and views, rename file to correspond
to the model and add migration script
@ThomasBinsfeld ThomasBinsfeld force-pushed the 16.0-mig-delivery_dropoff_site branch from 4dcc641 to 9e53b66 Compare July 1, 2024 07:16
@ThomasBinsfeld
Copy link

Hi @jdoutreloux Can you rebase plz?

Done

@rousseldenis
Copy link
Sponsor Contributor

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

On my way to merge this fine PR!
Prepared branch 16.0-ocabot-merge-pr-754-by-rousseldenis-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 3ed6a52 into OCA:16.0 Jul 1, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at e892f9a. Thanks a lot for contributing to OCA. ❤️

@ThomasBinsfeld ThomasBinsfeld deleted the 16.0-mig-delivery_dropoff_site branch July 1, 2024 07:26
@jdoutreloux
Copy link
Contributor Author

Thanks for the rebase @ThomasBinsfeld

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flotho flotho flotho approved these changes

@gaelTorrecillas gaelTorrecillas gaelTorrecillas approved these changes

@ThomasBinsfeld ThomasBinsfeld ThomasBinsfeld approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@DorianMAG DorianMAG DorianMAG approved these changes

Assignees
No one assigned
Labels
approved merged 🎉 migration needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Milestone
16.0
Development

Successfully merging this pull request may close these issues.

None yet