[17.0][ADD] delivery_sendcloud #838
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ByteMeAsap
force-pushed
the
17.0-add-delivery_sendcloud
branch
2 times, most recently
from
0dfd37f
to
0299f56
Compare
|
@pedrobaeza , can we please get the pre-commit issue checked? it is giving an error as Parsing error: Unexpected token = for the backend.esm.js file, but it seems to be fine. Also, have this module reviewed |
|
I can't say too much about JS, as I'm not an expert, but it seems putting a static variable there is not allowed. Anyway, using such variables should be avoided. About reviewing, I don't know this API nor I'm interested in it for now, so you should look for other reviewers. You can review other PRs and ask in exchange that they review yours. |
ByteMeAsap
force-pushed
the
17.0-add-delivery_sendcloud
branch
17 times, most recently
from
b561e97
to
978decd
Compare
pre-commit fixes Added README.rst file pre-commit fix Updated test scripts Updated test scripts Updated test scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts Updated Test Scripts
ByteMeAsap
force-pushed
the
17.0-add-delivery_sendcloud
branch
from
978decd
to
7296220
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
delivery_sendcloud module provides sendcloud shipping integration with Odoo
This module mostly implements what's described in https://docs.sendcloud.sc/api/v2/shipping/
Full documentation for developers is in https://docs.sendcloud.sc/.
This module works for the Community Edition as well as the Enterprise Edition.