Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] delivery_purchase : fix module install on demo data #842

Merged
merged 1 commit into from
Jul 9, 2024
Merged

[14.0][FIX] delivery_purchase : fix module install on demo data #842

merged 1 commit into from
Jul 9, 2024
+43 −4

Conversation

jbaudoux
Copy link
Contributor

While testing this module, I encountered some issues during installation and testing with demo data:

  • initialization of PO delivery price is mixing POs in the loop
  • if you have installed a carrier delivery_xxx module that does not implement purchase price, then PO confirmation was crashing

cc @pedrobaeza

@pedrobaeza
Copy link
Member

You can squash both commits, as they belong to the same concept

@jbaudoux
delivery_purchase: fixes
07ae9d7 
* fix po _compute_delivery_price
* support delivery_xxx modules:
  Allow installation of delivery_xxx modules without requiring purchase
  price implementation
@jbaudoux
Copy link
Contributor Author

You can squash both commits, as they belong to the same concept

@pedrobaeza done

hparfr
hparfr approved these changes Jul 9, 2024
View reviewed changes
Copy link
Contributor

@hparfr hparfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 14.0-ocabot-merge-pr-842-by-hparfr-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 242dc30 into OCA:14.0 Jul 9, 2024
7 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at f39f8ad. Thanks a lot for contributing to OCA. ❤️

@pedrobaeza pedrobaeza added this to the 14.0 milestone Jul 9, 2024
@pedrobaeza
Copy link
Member

Please fw-port the fix

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@hparfr hparfr hparfr approved these changes

Assignees
No one assigned
Labels
approved merged 🎉
Projects
None yet
Milestone
14.0
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jbaudoux @pedrobaeza @OCA-git-bot @hparfr