[IMP] dms_version: constrain that attachments storage cannot be versi…

…oned

dms_version/models/dms_directory.py

@@ -2,7 +2,8 @@
 # Copyright 2021 Tecnativa - Víctor Martínez
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import api, fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import ValidationError
 
 
 class DmsDirectory(models.Model):
@@ -13,6 +14,19 @@ class DmsDirectory(models.Model):
         help="Indicates if files have an active version control.",
     )
 
+    @api.constrains("has_versioning")
+    def _check_can_be_versioned(self):
+        for directory in self:
+            if (
+                directory.has_versioning
+                and directory.storage_id_save_type == "attachment"
+            ):
+                msg = _(
+                    "Attachment storages cannot be versioned. "
+                    "Please check the directory storage."
+                )
+                raise ValidationError(msg)
+
     @api.onchange("storage_id")
     def _onchange_storage_id(self):
         for record in self:

dms_version/models/dms_file.py

@@ -3,6 +3,7 @@
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
 from odoo import _, api, exceptions, fields, models
+from odoo.exceptions import ValidationError
 
 
 class DmsFile(models.Model):
@@ -71,6 +72,19 @@ class DmsFile(models.Model):
         )
     ]
 
+    @api.constrains("has_versioning")
+    def _check_can_be_versioned(self):
+        for file in self:
+            if (
+                file.has_versioning
+                and file.directory.storage_id_save_type == "attachment"
+            ):
+                msg = _(
+                    "Attachment storages cannot be versioned. "
+                    "Please check the directory storage."
+                )
+                raise ValidationError(msg)
+
     @api.constrains("unrevisioned_name", "revision_number", "directory_id")
     def check_unique_name_revision_number(self):
         if self.env.context.get("ignore_revision_unique"):

dms_version/models/dms_storage.py

@@ -2,7 +2,8 @@
 # Copyright 2021 Tecnativa - Víctor Martínez
 # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl).
 
-from odoo import fields, models
+from odoo import _, api, fields, models
+from odoo.exceptions import ValidationError
 
 
 class DmsStorage(models.Model):
@@ -12,3 +13,9 @@ class DmsStorage(models.Model):
         default=False,
         help="Indicates if files have an active version control.",
     )
+
+    @api.constrains("has_versioning")
+    def _check_can_be_versioned(self):
+        for storage in self:
+            if storage.has_versioning and storage.save_type == "attachment":
+                raise ValidationError(_("Attachment storages cannot be versioned."))