Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[13.0][MIG] dms #1

Merged
merged 22 commits into from
Jul 6, 2020
Merged

[13.0][MIG] dms #1

merged 22 commits into from
Jul 6, 2020

Conversation

etobella
Copy link
Member

Creating DMS from MuK original module.

Still WIP but comments are welcome

@pedrobaeza @geluboros @AntoniRomera @dalonsod @jarroyomorales

@pedrobaeza
Copy link
Member

cc @keshrath

@pedrobaeza pedrobaeza added this to the 13.0 milestone May 19, 2020
@etobella etobella force-pushed the 13.0-dms branch 3 times, most recently from db2e337 to e7e0b4d Compare May 19, 2020 21:17
emagdalenaC2i
emagdalenaC2i reviewed May 19, 2020
View reviewed changes
dms/models/directory.py Outdated Show resolved Hide resolved
dms/models/dms_file.py Outdated Show resolved Hide resolved
dms/readme/USAGE.rst Outdated Show resolved Hide resolved
@etobella
Copy link
Member Author

@emagdalenaC2i Comments attended 😉

@etobella etobella force-pushed the 13.0-dms branch 5 times, most recently from 6a10227 to 0f2eee4 Compare July 6, 2020 10:29
@etobella
Copy link
Member Author

etobella commented Jul 6, 2020

There was a small bug when clicking on the path. Now it is fixed 😉

@etobella
Copy link
Member Author

etobella commented Jul 6, 2020

@keshrath @pedrobaeza I have made a first approach of a migration script for muk_dms, it was necessary to add muk_dms on the apriory.py file from OpenUpgrade

@etobella etobella force-pushed the 13.0-dms branch 3 times, most recently from 22a1f76 to 32a8318 Compare July 6, 2020 13:33
@pedrobaeza
Copy link
Member

@etobella please leave out of this initial PR the migration scripts, as it will delay the merge of the working 13.0 module. You can do a PR immediately and I'll check it. Right now I'm about merging with final review!

@etobella
Copy link
Member Author

etobella commented Jul 6, 2020

Perfect!! I have created a branch for the migration script. Once this is merged, we can publish the PR in order to review it 😉

@etobella
Copy link
Member Author

etobella commented Jul 6, 2020

If anyone wants to continue with the migration he can take the branch:

https://github.com/tegin/dms/tree/13.0-dms-migration

@etobella
Copy link
Member Author

etobella commented Jul 6, 2020

Also, a backport to 12.0 of the module can be found on our repo:

https://github.com/tegin/dms/tree/12.0-dms

@pedrobaeza
Copy link
Member

Let's proceed with the merge. Thanks to all the involved.

/ocabot merge nobump

@OCA-git-bot
Copy link
Contributor

Hey, thanks for contributing! Proceeding to merge this for you.
Prepared branch 13.0-ocabot-merge-pr-1-by-pedrobaeza-bump-nobump, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 6541ba2 into OCA:13.0 Jul 6, 2020
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 35ca97a. Thanks a lot for contributing to OCA. ❤️

@etobella etobella mentioned this pull request Jul 6, 2020
Closed
@agent-z28
Copy link

WOW!!!!!

@etobella etobella mentioned this pull request Jul 8, 2020
Closed
7 tasks
@etobella etobella mentioned this pull request Jul 27, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emagdalenaC2i emagdalenaC2i emagdalenaC2i left review comments

@pedrobaeza pedrobaeza pedrobaeza approved these changes

@rousseldenis rousseldenis rousseldenis approved these changes

@LoisRForgeFlow LoisRForgeFlow LoisRForgeFlow approved these changes

@dalonsod dalonsod Awaiting requested review from dalonsod

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
13.0
Development

Successfully merging this pull request may close these issues.

None yet