[12.0][FIX] dms: me cases admin and demo users have previously in 'Show private access' group and causes some tests to fail. #112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think you should use other user for tests instead of that 2. |
Yes, totally agree but that would make it necessary to change all tests now. In the future it would be a good idea to redo the tests with users created in the tests (not admin and demo). |
|
Then instead of this, just remove both users from the group on the setup of the test instead of doing this ugly |
…w private access' group and causes some tests to fail. (Standarize according to 13.0)
victoralmau
force-pushed
the
12.0-fix-dms-test_storage_attachment
branch
from
95d6790
to
3463243
Compare
joao-p-marques
approved these changes
Jul 9, 2021
pedrobaeza
approved these changes
Jul 9, 2021
|
/ocabot merge patch |
|
On my way to merge this fine PR! |
yajo
approved these changes
Jul 9, 2021
|
Congratulations, your PR was merged at aba3b05. Thanks a lot for contributing to OCA. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases admin and demo users have previously in 'Show private access' group and causes some tests to fail. (Standarize according to 13.0) (It's fixed directly in #107)
Please @pedrobaeza and @yajo can you review it?
@Tecnativa