Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[14.0][FIX] copier update #273

Merged
merged 2 commits into from
Nov 20, 2023
Merged

[14.0][FIX] copier update #273

merged 2 commits into from
Nov 20, 2023
+55 −26

Conversation

yweng8111
Copy link

Copier Update

@yweng8111
Copy link
Author

yweng8111 commented Nov 20, 2023 •
edited
Loading

@pedrobaeza
There are still some pre-commit errors, that I didn't get locally.

@yweng8111
Copy link
Author

yweng8111 commented Nov 20, 2023 •
edited
Loading

@pedrobaeza
OK, I see. I didn't get those errors, because I didn't change the files in directory dms. Should I fix these errors in this PR?

@pedrobaeza pedrobaeza changed the title [FIX] copier update [14.0][FIX] copier update Nov 20, 2023
@pedrobaeza
Copy link
Member

Yes, there's a new check. Please remove the string attribute in tree:

dms/views/tag.xml:104 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/category.xml:30 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/dms_file.xml:313 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/dms_file.xml:588 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/directory.xml:372 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/directory.xml:506 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/directory.xml:523 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/directory.xml:560 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/directory.xml:573 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/storage.xml:100 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/storage.xml:198 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/dms_access_groups_views.xml:13 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/dms_access_groups_views.xml:55 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/dms_access_groups_views.xml:65 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/dms_access_groups_views.xml:73 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/dms_access_groups_views.xml:83 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]
dms/views/dms_access_groups_views.xml:94 Deprecated "<tree string=..." - [xml-deprecated-tree-attribute]

@yweng8111
Copy link
Author

Yes, there's a new check. Please remove the string attribute in tree:

Thanks It works now.

pedrobaeza
pedrobaeza approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@pedrobaeza pedrobaeza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ocabot merge minor

@OCA-git-bot
Copy link
Contributor

This PR looks fantastic, let's merge it!
Prepared branch 14.0-ocabot-merge-pr-273-by-pedrobaeza-bump-minor, awaiting test results.

@OCA-git-bot OCA-git-bot merged commit 01e7393 into OCA:14.0 Nov 20, 2023
5 checks passed
@OCA-git-bot
Copy link
Contributor

Congratulations, your PR was merged at 218ddfa. Thanks a lot for contributing to OCA. ❤️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pedrobaeza pedrobaeza pedrobaeza approved these changes

Assignees
No one assigned
Labels
merged 🎉
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yweng8111 @pedrobaeza @OCA-git-bot