[16.0][MIG] dms_field: Migration to 16.0 #339

CarlosRoca13 · 2024-05-31T18:04:41Z

cc @Tecnativa TT48507

This migration has renamed the dms_tree view to dms_list due to an incompatibility with the tree view.
Adapt code to owl and use reactivity that it offers
Use new drag and drop as it is used on dms module

ping @victoralmau @pedrobaeza

CarlosRoca13 · 2024-05-31T18:05:59Z

Set as draft because drag and drop is not already implemented, but the module is usable yet

pedrobaeza · 2024-05-31T18:07:10Z

/ocabot migration dms_field

dms_field/views/dms_field_template_views.xml

dms_field/models/dms_field_template.py

CarlosRoca13 · 2024-06-04T08:22:32Z

@victoralmau Changes done and drag & drop added

victoralmau

The same suggestion for all occurrences.

victoralmau · 2024-06-06T11:27:14Z

dms_field/tests/test_dms_field.py

+            res_model=cls.template._name, res_id=cls.template.id
+        )
+        template_ctx.create_dms_directory()
+        cls.template.refresh()


Suggested change

cls.template.refresh()

cls.template.invalidate_model()

CarlosRoca13 · 2024-06-10T05:59:34Z

@victoralmau Changes done!

Added migration script to change the type of ir.ui.view records that keeps dms_tree type

dms_field/models/base.py

CarlosRoca13 · 2024-06-10T10:10:12Z

Done! 😄

pedrobaeza

I don't understand why renaming from dms_tree to dms_list and causes potential problems.

Another thing is that the README is not explaining how to enable this in any model.

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: dms-15.0/dms-15.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_field/

…n as default state Before this change, when lauching the reload, the child directories of the reloaded one are opened too. By doing at this step and not setting the default state, the reloads are done just for the implied nodes. Furthermore, the code is improved to just reload the directories that have being changed.

Currently translated at 100.0% (75 of 75 strings) Translation: dms-15.0/dms-15.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_field/es/

With hr_dms_field The steps to reproduce the problem are: 1. Open Employee 2. Go to Documents Page 3. Drop a file on a directory 4. Go to another Employee 5. Try to drop a file The file can not be dropped.

In the migration, the view type is changed from dms_tree to dms_list. That's because in this point https://github.com/odoo/odoo/blob/16.0/addons/web/static/src/views/fields/field.js#L282 the 'tree' string is replaced by 'list' what is causing problems trying to set the view type as it was before.

A parent directory can be set in templates, if set, the directory that is created linked to a record will be a "child" of that directory. TT48650

…ors when creating directories from a template. Example of use case: - Create a partner. - Create a template linked to partners. - Create a directory through the template. - An access group linked to the partner is created. - Delete the partner directory. - Creates a new directory through the template. - No error will occur and the previous access group will be re-used.

CarlosRoca13 · 2024-06-19T06:41:10Z

I have added the explanation for the change from dms_tree to dms_list in the commit message and added in CONFIGURE.rst the way to use the embedded view in any model

pedrobaeza · 2024-06-19T06:55:23Z

I'm testing the module and the eye button (or the button "Open" in the right part) is not working properly: for PDF files, it downloads it instead of previewing it, and for other files without preview feature, it gets a black popup:

CarlosRoca13 · 2024-06-19T07:22:46Z

So I'm seeing the pdf ok..

For other files it is how it is working now the dms, the preview is delegated to the navigator if you click on the preview image of "other files" you will have the same result

pedrobaeza · 2024-06-19T07:30:16Z

Please use Firefox for PDF preview. It's not working well there. About the other, I think it the button can be faded if not available.

CarlosRoca13 · 2024-06-19T08:26:20Z

It is something about your navigator...

Test on firefox:

…ring Now the process will be as follows: - The auto-generated access group will be created. - The user will be defined in explicit_user_ids of the group created in the previous step. In the directory created (from the corresponding record) the auto-generated group (for the user to have access) + the access groups that the template had will be used.

pedrobaeza

OK then...

/ocabot merge nobump

OCA-git-bot · 2024-06-19T16:41:20Z

What a great day to merge this nice PR. Let's do it!
Prepared branch 16.0-ocabot-merge-pr-339-by-pedrobaeza-bump-nobump, awaiting test results.

OCA-git-bot · 2024-06-19T16:46:47Z

Congratulations, your PR was merged at 83073f4. Thanks a lot for contributing to OCA. ❤️

CarlosRoca13 marked this pull request as draft May 31, 2024 18:05

OCA-git-bot added this to the 16.0 milestone May 31, 2024

OCA-git-bot mentioned this pull request May 31, 2024

Migration to version 16.0 #213

Open

6 tasks

victoralmau mentioned this pull request Jun 3, 2024

[16.0][MIG] dms_field_auto_classification: Migration to 16.0 #336

Merged

1 task

victoralmau suggested changes Jun 3, 2024

View reviewed changes

dms_field/views/dms_field_template_views.xml Outdated Show resolved Hide resolved

dms_field/models/dms_field_template.py Outdated Show resolved Hide resolved

victoralmau mentioned this pull request Jun 3, 2024

[16.0][MIG] hr_dms_field: Migration to 16.0 #340

Merged

1 task

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch 2 times, most recently from 1f32d57 to 36fc321 Compare June 4, 2024 08:21

CarlosRoca13 marked this pull request as ready for review June 4, 2024 08:21

victoralmau approved these changes Jun 4, 2024

View reviewed changes

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch from 36fc321 to 1f39e43 Compare June 4, 2024 13:44

victoralmau suggested changes Jun 6, 2024

View reviewed changes

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch 3 times, most recently from b869429 to dbc1671 Compare June 10, 2024 05:58

victoralmau approved these changes Jun 10, 2024

View reviewed changes

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch 2 times, most recently from 1229741 to 9c29a7c Compare June 10, 2024 07:20

pedrobaeza reviewed Jun 10, 2024

View reviewed changes

dms_field/models/base.py Outdated Show resolved Hide resolved

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch from 9c29a7c to df51b5e Compare June 10, 2024 10:09

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch from df51b5e to a6ca55c Compare June 10, 2024 11:37

pedrobaeza reviewed Jun 18, 2024

View reviewed changes

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch from aba8ff3 to 6510d67 Compare June 18, 2024 11:23

Jaime Arroyo and others added 2 commits June 19, 2024 08:17

[12.0][ADD] dms_field: New view

405a3a0

[IMP] dms_field: create dms records

88361e2

oca-ci and others added 8 commits June 19, 2024 08:17

[UPD] Update dms_field.pot

7273b68

Update translation files

692fd24

Updated by "Update PO files to match POT (msgmerge)" hook in Weblate. Translation: dms-15.0/dms-15.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_field/

[BOT] post-merge updates

940ccf6

Translated using Weblate (Spanish)

87a8731

Currently translated at 100.0% (75 of 75 strings) Translation: dms-15.0/dms-15.0-dms_field Translate-URL: https://translation.odoo-community.org/projects/dms-15-0/dms-15-0-dms_field/es/

[FIX] dms_field: Keep dms active when changing view

86ab69f

With hr_dms_field The steps to reproduce the problem are: 1. Open Employee 2. Go to Documents Page 3. Drop a file on a directory 4. Go to another Employee 5. Try to drop a file The file can not be dropped.

[BOT] post-merge updates

fc210c1

[IMP] dms_field: pre-commit stuff

f867d97

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch 2 times, most recently from 2fcf78c to 652453c Compare June 19, 2024 06:37

CarlosRoca13 and others added 3 commits June 19, 2024 08:39

[IMP] dms_field: Add Parent directory option to templates

36a2b0b

A parent directory can be set in templates, if set, the directory that is created linked to a record will be a "child" of that directory. TT48650

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch from 652453c to 3db3da9 Compare June 19, 2024 06:39

CarlosRoca13 force-pushed the 16.0-MIG-dms_field branch from 3db3da9 to 0393143 Compare June 19, 2024 13:02

pedrobaeza approved these changes Jun 19, 2024

View reviewed changes

OCA-git-bot added the approved label Jun 19, 2024

OCA-git-bot added the bot is merging ⏳ label Jun 19, 2024

OCA-git-bot merged commit be90069 into OCA:16.0 Jun 19, 2024
7 checks passed

OCA-git-bot added merged 🎉 and removed bot is merging ⏳ labels Jun 19, 2024

pedrobaeza deleted the 16.0-MIG-dms_field branch June 19, 2024 16:47

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[16.0][MIG] dms_field: Migration to 16.0 #339

[16.0][MIG] dms_field: Migration to 16.0 #339

CarlosRoca13 commented May 31, 2024 •

edited by pedrobaeza

Loading

CarlosRoca13 commented May 31, 2024

pedrobaeza commented May 31, 2024

CarlosRoca13 commented Jun 4, 2024

victoralmau left a comment

victoralmau Jun 6, 2024 •

edited

Loading

CarlosRoca13 commented Jun 10, 2024

CarlosRoca13 commented Jun 10, 2024

pedrobaeza left a comment

CarlosRoca13 commented Jun 19, 2024 •

edited

Loading

pedrobaeza commented Jun 19, 2024

CarlosRoca13 commented Jun 19, 2024

pedrobaeza commented Jun 19, 2024

CarlosRoca13 commented Jun 19, 2024

pedrobaeza left a comment

OCA-git-bot commented Jun 19, 2024

OCA-git-bot commented Jun 19, 2024

[16.0][MIG] dms_field: Migration to 16.0 #339

[16.0][MIG] dms_field: Migration to 16.0 #339

Conversation

CarlosRoca13 commented May 31, 2024 • edited by pedrobaeza Loading

CarlosRoca13 commented May 31, 2024

pedrobaeza commented May 31, 2024

CarlosRoca13 commented Jun 4, 2024

victoralmau left a comment

Choose a reason for hiding this comment

victoralmau Jun 6, 2024 • edited Loading

Choose a reason for hiding this comment

CarlosRoca13 commented Jun 10, 2024

CarlosRoca13 commented Jun 10, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

CarlosRoca13 commented Jun 19, 2024 • edited Loading

pedrobaeza commented Jun 19, 2024

CarlosRoca13 commented Jun 19, 2024

pedrobaeza commented Jun 19, 2024

CarlosRoca13 commented Jun 19, 2024

pedrobaeza left a comment

Choose a reason for hiding this comment

OCA-git-bot commented Jun 19, 2024

OCA-git-bot commented Jun 19, 2024

CarlosRoca13 commented May 31, 2024 •

edited by pedrobaeza

Loading

victoralmau Jun 6, 2024 •

edited

Loading

CarlosRoca13 commented Jun 19, 2024 •

edited

Loading