-
-
Notifications
You must be signed in to change notification settings - Fork 488
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pythonic Inheritance issue in Shop by brand module. #105
Comments
CCing @pedrobaeza @yajo Can you please help me out to overcome this situation ? I am migrating website_sale_recently_viewed_products in v9. I need to import the class website_sale and because of this pythonic override, I am not able to import the class. Thanks in advance. |
This is not pythonic, it's monkeypatching. You have to remove that and use inheritance. |
@pedrobaeza Thanks for your prompt response. Looking for the solution. 👍 |
Yeah, just remove that line and you are done. (if there is no other monkey patch.) |
Closing as done |
Hello Community,
I am facing the issue in importing website_sale class of website_sale module.
The Issue is raised because of the pythonic override of website_sale class.
Here you will find the reference.
https://github.com/OCA/e-commerce/blob/9.0/website_sale_product_brand/controllers/main.py#L59
Can anybody please help me to fix this issue ?
Regards.
#103
The text was updated successfully, but these errors were encountered: