[9.0][BUG] website_sale_product_brand: Error on search

[lasley]

There is an error caused by website_sale_product_brand when you perform a search in the Shop (website_sale search):

Traceback (most recent call last):
  File "/root/odoo-9.0/addons/website/models/ir_http.py", line 242, in _handle_exception
    response = super(ir_http, self)._handle_exception(exception)
  File "/.repo_requirements/odoo/openerp/addons/base/ir/ir_http.py", line 158, in _handle_exception
    return request._handle_exception(exception)
  File "/.repo_requirements/odoo/openerp/http.py", line 786, in _handle_exception
    return super(HttpRequest, self)._handle_exception(exception)
  File "/.repo_requirements/odoo/openerp/addons/base/ir/ir_http.py", line 183, in _dispatch
    result = request.dispatch()
  File "/.repo_requirements/odoo/openerp/http.py", line 845, in dispatch
    r = self._call_function(**self.params)
  File "/.repo_requirements/odoo/openerp/http.py", line 321, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/.repo_requirements/odoo/openerp/service/model.py", line 118, in wrapper
    return f(dbname, *args, **kwargs)
  File "/.repo_requirements/odoo/openerp/http.py", line 314, in checked_call
    result = self.endpoint(*a, **kw)
  File "/.repo_requirements/odoo/openerp/http.py", line 964, in __call__
    return self.method(*args, **kw)
  File "/.repo_requirements/odoo/openerp/http.py", line 514, in response_wrap
    response = f(*args, **kw)
  File "/root/build/OCA/e-commerce/website_sale_wishlist/controllers/main.py", line 22, in shop
    page, category, search, ppg, **post)
  File "/.repo_requirements/odoo/openerp/http.py", line 514, in response_wrap
    response = f(*args, **kw)
  File "/root/build/OCA/e-commerce/website_sale_product_brand/controllers/main.py", line 26, in shop
    context.setdefault('brand_id', int(brand))
ValueError: invalid literal for int() with base 10: 'imac'

I have reproduced on v9 Runbot. v8 is fine.

[pedrobaeza]

Can you check if after merging #220 is solved?

[lasley]

@pedrobaeza - looks to still be an issue on v9 Runbot. Traceback:

2017-11-27 18:47:08,482 172 ERROR openerp_test openerp.addons.website.models.ir_http: 500 Internal Server Error:

Traceback (most recent call last):
File "/home/odoo/odoo-9.0/addons/website/models/ir_http.py", line 242, in _handle_exception
response = super(ir_http, self)._handle_exception(exception)
File "/.repo_requirements/odoo/openerp/addons/base/ir/ir_http.py", line 158, in _handle_exception
return request._handle_exception(exception)
File "/.repo_requirements/odoo/openerp/http.py", line 788, in _handle_exception
return super(HttpRequest, self)._handle_exception(exception)
File "/.repo_requirements/odoo/openerp/addons/base/ir/ir_http.py", line 183, in _dispatch
result = request.dispatch()
File "/.repo_requirements/odoo/openerp/http.py", line 847, in dispatch
r = self._call_function(**self.params)
File "/.repo_requirements/odoo/openerp/http.py", line 323, in _call_function
return checked_call(self.db, *args, **kwargs)
File "/.repo_requirements/odoo/openerp/service/model.py", line 118, in wrapper
return f(dbname, *args, **kwargs)
File "/.repo_requirements/odoo/openerp/http.py", line 316, in checked_call
result = self.endpoint(*a, **kw)
File "/.repo_requirements/odoo/openerp/http.py", line 966, in __call__
return self.method(*args, **kw)
File "/.repo_requirements/odoo/openerp/http.py", line 516, in response_wrap
response = f(*args, **kw)
File "/home/odoo/build/OCA/e-commerce/website_sale_wishlist/controllers/main.py", line 22, in shop
page, category, search, ppg, **post)
File "/.repo_requirements/odoo/openerp/http.py", line 516, in response_wrap
response = f(*args, **kw)
File "/home/odoo/build/OCA/e-commerce/website_sale_product_brand/controllers/main.py", line 26, in shop
context.setdefault('brand_id', int(brand))
ValueError: invalid literal for int() with base 10: 'test'

[pedrobaeza]

Then it should be another thing. I haven't analyzed it.

[lasley]

Neither have I - I don't actually use website_sale_product_brand, it was just something I noticed while developing #157. It seems like the search text is being passed to the shop controller method as brand instead of search.

[github-actions]

There hasn't been any activity on this issue in the past 6 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this issue to never become stale, please ask a PSC member to apply the "no stale" label.