[ADD][website_sale_wishlist] Wishlist for your online shop. #122

yajo · 2016-08-26T09:41:55Z

Allow your visitors and users to wishlist your products and have a shortcut for seeing them.

Wishlisted products are stored in the session for public users, and linked to the user if s/he is logged in.

@Tecnativa

rafaelbn · 2016-08-30T17:02:20Z

Tested in runbot 👍

rafaelbn · 2016-08-30T17:03:40Z

@yajo could you increase coverage?

cc @pedrobaeza @sergio-teruel @carlosdauden

sergio-teruel · 2016-08-30T17:21:22Z

Tested in runbot 👍

atchuthan · 2016-08-31T05:35:29Z

website_sale_wishlist/__openerp__.py

+    "category": "Website",
+    "website": "https://tecnativa.com/",
+    "author": "Tecnativa, Odoo Community Association (OCA)",
+    "license": "LGPL-3",


For OCA modules, the license is generally AGPL-3.

OCA admits any OSI approved license (including this). We have chosen this license for website related modules for allowing to put specific stuff on top of these modules and for not being forced to give the source code of this to any of the visitors of the website.

atchuthan · 2016-08-31T05:59:29Z

Tested in runbot 👍

(Wishlist/Suggestion)
When we add a product using "add cart" from wishlist window, we could probably remove the wishlist of the added product.

rafaelbn · 2016-08-31T07:04:19Z

Hi @atchuthan ,

"When we add a product using "add cart" from wishlist window, we could probably remove the wishlist of the added product."

That is what cart do, wishlist must be persistent as it could be used for you favourites products

yajo · 2016-08-31T07:05:17Z

Thanks @atchuthan, I thought on that, but it seems to me that maybe users want to use it as a "bookmark", or they could want to buy again those same products later, so I prefer this module not to be so smart. Removing them is just one click away.

sergio-teruel · 2016-08-31T07:07:15Z

I think the same that Yajo

pedrobaeza · 2016-09-06T13:46:11Z

website_sale_wishlist/data/ir_cron.yml

@@ -0,0 +1,9 @@
+# Copyright 2016 Jairo Llopis <jairo.llopis@tecnativa.com>
+# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl).
+- !record {id: garbage_collector, model: ir.cron}:


Remember me why do we need this?

This is for removing wishlist items for non-users and sessions that no longer exist

antespi · 2016-09-09T13:09:10Z

👍 tested in runbot

rafaelbn · 2016-09-12T20:56:31Z

@yajo please review coverage, thanks!

Functional test 👍

pedrobaeza · 2016-09-13T20:06:18Z

@yajo, please check pending comments, and it would be good to add to the README the reasoning about not removing the element when adding to cart

mFlayyan · 2016-09-27T14:41:23Z

tested on runbot: working 👍
when tried to build I got an issue in crons 👎
BackTrace is:
openerp.addons.base.ir.ir_cron:106 _handle_callback_exception

Call of self.pool.get('wishlist.product')._garbage_collector(cr, uid, _()) failed in Job 6
Traceback (most recent call last):
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155205-122-c9a12b/openerp/addons/base/ir/ir_cron.py", line 129, in _callback
getattr(model, method_name)(cr, uid, *args)
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155205-122-c9a12b/openerp/api.py", line 250, in wrapper
return old_api(self, *args, *_kwargs)
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155205-122-c9a12b/openerp/api.py", line 354, in old_api
result = method(recs, _args, *_kwargs)
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155205-122-c9a12b/openerp/addons/website_sale_wishlist/models/wishlist_product.py", line 89, in _garbage_collector
("user_id", "=", False),
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155205-122-c9a12b/openerp/api.py", line 248, in wrapper
return new_api(self, _args, *_kwargs)
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155205-122-c9a12b/openerp/addons/website_sale_wishlist/models/wishlist_product.py", line 108, in unlink
self._clear_methods_cache()
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155205-122-c9a12b/openerp/api.py", line 248, in wrapper
return new_api(self, _args, *_kwargs)
File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155205-122-c9a12b/openerp/addons/website_sale_wishlist/models/wishlist_product.py", line 96, in _clear_methods_cache
Product = request.env["product.template"]
File "/srv/openerp/instances/openerp-oca-runbot/sandbox/local/lib/python2.7/site-packages/werkzeug/local.py", line 338, in getattr
return getattr(self._get_current_object(), name)
File "/srv/openerp/instances/openerp-oca-runbot/sandbox/local/lib/python2.7/site-packages/werkzeug/local.py", line 297, in _get_current_object
return self.__local()
File "/srv/openerp/instances/openerp-oca-runbot/sandbox/local/lib/python2.7/site-packages/werkzeug/local.py", line 132, in _lookup
raise RuntimeError('object unbound')
RuntimeError: object unbound

yajo · 2016-09-28T07:27:23Z

This is weird, the test fails, but Travis is not ❌. Do not trust him, I have to fix the test.

atchuthan · 2016-09-29T10:30:00Z

website_sale_product_brand/views/product_brand.xml

    <record id="menu_website_sale_brand" model="website.menu">
        <field name="name">Shop by Brand</field>
        <field name="url">/page/product_brands</field>
-        <field name="parent_id" ref="website_sale.menu_shop" />
+        <field name="sequence" type="int">25</field>
+        <field name="parent_id" ref="website_sale.main_menu" />


external id seems to be wrong, website.main_menu
https://github.com/odoo/odoo/blob/9.0/addons/website/data/data.xml#L12

Runbot fails due to this

File "/srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155288-122-6df6af/openerp/addons/base/ir/ir_model.py", line 974, in xmlid_lookup raise ValueError('External ID not found in the system: %s' % (xmlid)) ParseError: "External ID not found in the system: website_sale.main_menu" while parsing /srv/openerp/instances/openerp-oca-runbot/parts/odoo-extra/runbot/static/build/3155288-122-6df6af/openerp/addons/website_sale_product_brand/views/product_brand.xml:61, near <record id="menu_website_sale_brand" model="website.menu"> <field name="name">Shop by Brand</field> <field name="url">/page/product_brands</field> <field name="sequence" type="int">25</field> <field name="parent_id" ref="website_sale.main_menu"/> </record>

For more info, check the runbot log

atchuthan · 2016-09-30T06:53:21Z

Runbot test 👍

yajo · 2016-09-30T11:00:25Z

Fun.
Travis' test fails, but it gets green. It is affected by odoo/odoo#13743.
If you go to runbot and open a JS console and execute odoo.__DEBUG__.services['web.Tour'].run('test_website_sale_wishlist', 'test') as the public user, test works.
In local machine too.

lasley · 2016-09-30T14:40:03Z

website_sale_product_brand/data/website_menu.xml

@@ -0,0 +1,14 @@
+<?xml version="1.0" encoding="utf-8"?>
+<openerp>


<odoo noupdate="1">

Cool, I did not know that shortcut!

lasley · 2016-09-30T14:43:24Z

website_sale_wishlist/demo/assets.xml

+     License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl). -->
+<odoo>
+
+<template id="assets_frontend_demo" inherit_id="website.assets_frontend">


XML ID should match the inherit_id

Not in this case, because there is already an assets_frontend view in this addon, but this one is just for demo environments, to run tests.

lasley · 2016-09-30T14:43:51Z

website_sale_wishlist/models/res_users.py

+
+    current_session = fields.Char(compute="_compute_current_session")
+
+    @api.one


@api.one is deprecated

There's still a little hope 🙏 . I don't consider it deprecated until that PR is closed.

No hope, please fix

lasley · 2016-09-30T14:44:30Z

website_sale_wishlist/models/website.py

+from openerp.http import request
+
+
+class ResUsers(models.Model):


class Website

lasley · 2016-09-30T14:45:44Z

website_sale_wishlist/models/website.py

+            errors if you try to browse them when loaded from cache and cached
+            ones used a cursor that is now closed.
+        """
+        return [record["product_tmpl_id"][0] for record in


IMO this is a bit hard to read, maybe assign the search_read to a var then perform the generator? Non-blocking

lasley · 2016-09-30T14:46:44Z

website_sale_wishlist/models/wishlist_product.py

+
+
+class WishlistProduct(models.Model):
+    _name = "wishlist.product"


Possibly product.wishlist instead of creating a namespace for wishlists? I can't think of another use for a wishlist outside of products, and this would match pricelist naming

lasley · 2016-09-30T14:47:14Z

website_sale_wishlist/models/wishlist_product.py

+    ]
+
+    product_tmpl_id = fields.Many2one(
+        comodel_name="product.template",


Not possible to wishlist a variant?

Odoo works at template level in the e-commerce (product list, product detail). Variants are reflected through selection options in the template detail page.

Excellent, thanks for the elaboration.

lasley · 2016-09-30T14:50:37Z

website_sale_wishlist/models/wishlist_product.py

+        comodel_name="product.template",
+        string="Product",
+        required=True,
+        help="Wishlisted product.",


ondelete='cascade'?

oscarolar · 2016-10-11T09:33:42Z

website_sale_product_brand/views/product_brand.xml

@@ -6,10 +6,10 @@
    <template id="product_brands" name="Brands">
        <t t-call="website.layout">
            <t t-set="additional_title">Product Brands</t>
-            <div id="wrap" t-attf-class="wrapper"> 
+            <div id="wrap" t-attf-class="wrapper">


this is not a format string you may use t-att-class="wrapper".

Indeed this is a bug, but I prefer not to touch that. I'm only touching this file to remove a menu, seems like the space stripper changed this, but I'd prefer not to change something that could have a meaning without investigating, if you don't mind.

Fix it, now that you have opened the Pandora's box 😉

But I mean... should I change it for class="wrapper" or for t-att-class="wrapper"?

Yeah, good question. We need to see controller. Now I'm changing my vote for not touching this, hehe. I would bet t-att-class="wrapper", because although technically there's no % to format, it won't fail without them.

Then let's leave this as it is 😆

pedrobaeza · 2016-10-14T00:17:19Z

@yajo, please attend @lasley's requests about model renaming an ondelete, and I'll merge.

pedrobaeza · 2016-10-17T12:06:25Z

Check Travis

yajo · 2016-10-17T12:44:54Z

Rebased, let's see...

yajo · 2016-10-17T13:02:38Z

Please review, bots like this 😊 💚

bealdav · 2017-02-09T16:32:53Z

Hi @pedrobaeza @yajo @lasley and others.

Thanks for this nice feature

My customer would like to use it for V8.
I don't know difference between V8/V9 in website_sale_...

How much time do you think I need to backport in v8 ?

Thanks a lot.

pedrobaeza · 2017-02-09T16:34:09Z

The backport is not easy, as JS API has changed a lot in v9, but there's an alternative implementation for v8 in #130

bealdav · 2017-02-09T17:26:07Z

Thanks for your reply, I've seen it but my customer also seen https://www.odoo.com/apps/modules/9.0/wishlist/
available v8/v9 with 'move to cart' button with no equivalent in website_sale_wishlist.

pedrobaeza · 2017-02-09T17:31:16Z

But that one is not from OCA. See that the repo is git@github.com:techhighway/Product-Wishlist.git#8.0

bealdav · 2017-02-09T17:32:28Z

Yes, it was for your information, maybe pick up good ideas. Thanks

pedrobaeza · 2017-02-09T18:06:44Z

Well, we are not working more on this for now, but any PR is welcome 😉

[ADD][website_sale_wishlist] Wishlist for your online shop. Allow your visitors and users to wishlist your products and have a shortcut for seeing them. Wishlisted products are stored in the session for public users, and linked to the user if s/he is logged in.

[ADD][website_sale_wishlist] Wishlist for your online shop. Allow your visitors and users to wishlist your products and have a shortcut for seeing them. Wishlisted products are stored in the session for public users, and linked to the user if s/he is logged in. OCA Transbot updated translations from Transifex

[ADD][website_sale_wishlist] Wishlist for your online shop. Allow your visitors and users to wishlist your products and have a shortcut for seeing them. Wishlisted products are stored in the session for public users, and linked to the user if s/he is logged in.

[ADD][website_sale_wishlist] Wishlist for your online shop. Allow your visitors and users to wishlist your products and have a shortcut for seeing them. Wishlisted products are stored in the session for public users, and linked to the user if s/he is logged in. OCA Transbot updated translations from Transifex

rafaelbn added the needs review label Aug 30, 2016

rafaelbn added this to the 9.0 milestone Aug 30, 2016

atchuthan reviewed Aug 31, 2016
View reviewed changes

pedrobaeza reviewed Sep 6, 2016
View reviewed changes

atchuthan approved these changes Sep 15, 2016

View reviewed changes

yajo force-pushed the 9.0-website_sale_wishlist branch 2 times, most recently from 1a81d4e to 6df6afb Compare September 28, 2016 13:55

atchuthan reviewed Sep 29, 2016

View reviewed changes

yajo force-pushed the 9.0-website_sale_wishlist branch from 6df6afb to 2d68733 Compare September 29, 2016 10:42

pedrobaeza mentioned this pull request Sep 30, 2016

[8.0] New ecommerce wishlist module #130

Closed

lasley suggested changes Sep 30, 2016

View reviewed changes

yajo mentioned this pull request Oct 3, 2016

[ADD] basic modules + proper README OCA/website-cms#1

Closed

30 tasks

oscarolar reviewed Oct 11, 2016

View reviewed changes

yajo force-pushed the 9.0-website_sale_wishlist branch from 7c09edf to e8c25d3 Compare October 17, 2016 12:44

yajo added 2 commits October 17, 2016 14:44

Rename wishlist.product to product.wishlist.

833e7f6

Farewell, api.one...

5550b36

yajo force-pushed the 9.0-website_sale_wishlist branch from e8c25d3 to 5550b36 Compare October 17, 2016 12:44

lasley approved these changes Oct 17, 2016

View reviewed changes

pedrobaeza approved these changes Oct 18, 2016

View reviewed changes

pedrobaeza merged commit a6fb061 into OCA:9.0 Oct 18, 2016

pedrobaeza deleted the 9.0-website_sale_wishlist branch October 18, 2016 06:53

		@@ -0,0 +1,14 @@
		<?xml version="1.0" encoding="utf-8"?>
		<openerp>


		current_session = fields.Char(compute="_compute_current_session")

		@api.one

		from openerp.http import request


		class ResUsers(models.Model):



		class WishlistProduct(models.Model):
		_name = "wishlist.product"

[ADD][website_sale_wishlist] Wishlist for your online shop. #122

[ADD][website_sale_wishlist] Wishlist for your online shop. #122

Conversation

yajo commented Aug 26, 2016

rafaelbn commented Aug 30, 2016

rafaelbn commented Aug 30, 2016

sergio-teruel commented Aug 30, 2016

atchuthan Aug 31, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

atchuthan commented Aug 31, 2016

rafaelbn commented Aug 31, 2016

yajo commented Aug 31, 2016

sergio-teruel commented Aug 31, 2016

pedrobaeza Sep 6, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

antespi commented Sep 9, 2016 • edited Loading

rafaelbn commented Sep 12, 2016

pedrobaeza commented Sep 13, 2016

mFlayyan commented Sep 27, 2016 • edited Loading

yajo commented Sep 28, 2016

atchuthan Sep 29, 2016 • edited Loading

Choose a reason for hiding this comment

atchuthan commented Sep 30, 2016

yajo commented Sep 30, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza Oct 11, 2016 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pedrobaeza commented Oct 14, 2016

pedrobaeza commented Oct 17, 2016

yajo commented Oct 17, 2016

yajo commented Oct 17, 2016

bealdav commented Feb 9, 2017

pedrobaeza commented Feb 9, 2017

bealdav commented Feb 9, 2017

pedrobaeza commented Feb 9, 2017

bealdav commented Feb 9, 2017 • edited Loading

pedrobaeza commented Feb 9, 2017

atchuthan Aug 31, 2016 •

edited

Loading

pedrobaeza Sep 6, 2016 •

edited

Loading

antespi commented Sep 9, 2016 •

edited

Loading

mFlayyan commented Sep 27, 2016 •

edited

Loading

atchuthan Sep 29, 2016 •

edited

Loading

yajo commented Sep 30, 2016 •

edited

Loading

pedrobaeza Oct 11, 2016 •

edited

Loading

bealdav commented Feb 9, 2017 •

edited

Loading