[9.0][MIG] website_sale_require_login: Upgrade to v9 #124
Conversation
|
There's an strange merge commit in your history. You can also squash commits from "OCA bot". And please check Travis status. |
|
@pedrobaeza - This merge (0c08a7428b0a94697f6ebc1fc36939acf1c4cad8)? Isn't that required to bring the module onto v9 when it is not already present on that branch? Travis is failing because of lacking #125 as dependency most likely - I accidentally submitted the PRs backwards, with the dependency coming in after the dependent 😆 |
|
@lasley, you don't need to make any merge on your migration procedure. Please see https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-9.0 for several migration procedures (we are now trying the experimental one and seems to be easier). |
|
@pedrobaeza This module isn't on |
|
Please rebase this one |
Now a new button appears "Log in and checkout". Module website_sale_require_login depends on this one and removes the button for checkout without creating an account.
* Migrate website_sale_require_login to v9
lasley
force-pushed
the
release/9.0/website_sale_require_login
branch
from
25254af
to
af0595c
Compare
|
Rebased onto 9.0 |
There was a problem hiding this comment.
Seeing af0595c, everything seems correct, except these 2 little comments
| <https://github.com/OCA/e-commerce/issues>`_. In case of trouble, please | ||
| check there if your issue has already been reported. If you spotted it first, | ||
| help us smashing it by providing a detailed and welcomed `feedback | ||
| <https://github.com/OCA/ |
| "version": "9.0.1.0.0", | ||
| "category": "Website", | ||
| "website": "http://www.antiun.com", | ||
| "author": "Antiun Ingeniería, S.L., " |
There was a problem hiding this comment.
Please switch to the new company Tecnativa
* ReadMe to new template * Update `Antiun Ingeniería, S.L.` to `Tecnativa`
|
I'm so happy that inline comments are getting squashed when resolved again. I didn't realize how helpful that was until it was gone. Changes made btw |
This brings website_sale_require_login changes from #89, but with proper rebasing for author attribution.
There were also some parts that weren't upgraded & some JS Lints, so I handled those as well.
Dependent on merge of: