Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

9.0 website sale category megamenu #127

Closed
wants to merge 5 commits into from

Conversation

mFlayyan
Copy link

follow migration documentation to port website_sale_category_megamenu to V9

@hbrunn hbrunn added this to the 9.0 milestone Sep 20, 2016
@hbrunn
Copy link
Member

hbrunn commented Sep 20, 2016

👍

@@ -7,13 +7,13 @@
{
"name": "Website sale categories mega-menu",
"summary": "A megamenu to display product categories in the online shop",
"version": "8.0.1.0.1",
"version": "9.0.1.0.0",
"category": "Themes/Miscellaneous",
"website": "http://www.antiun.com",
"author": "Antiun Ingeniería S.L., Odoo Community Association (OCA)",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please switch Antiun to our new company Tecnativa?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

have you renamed your company to Tecnativa?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Yes, we have merged three companies in one: me as freelance (Serv. Tecnol. Avanzados - Pedro M. Baeza), Antiun and Incaser.

@pedrobaeza
Copy link
Member

Your changes have made that you require one more depth level to see the megamenu and thus, the megamenu looks awkward:

seleccion_002

This is the intended aspect in v8:

seleccion_001

@hbrunn
Copy link
Member

hbrunn commented Sep 20, 2016

that's weird, because I specifically asked @mFlayyan to cherry pick those commits as they are in 8.0 too: https://github.com/OCA/e-commerce/commits/8.0/website_sale_category_megamenu/views/layout.xml

@mFlayyan can you have a look if removing those commits fixes the issue (I doubt it to be honest)? If yes, we're happy without them, if not, keep the commits and add one on top that fixes it

@mFlayyan
Copy link
Author

mFlayyan commented Sep 21, 2016

this is the log history at my branch and the megamenu view , is there an
issue?

Kind Regards,
Mariam Flayyan
screenshot from 2016-09-21 12-28-09
screenshot from 2016-09-21 12-25-15

Copy link
Member

@atchuthan atchuthan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I tried to test the functionality in OCA runbot by creating multiple product category hierarchies
Computers -> Server -> Server sub1 -> Server sub2

image

I am unable to view the products available in Server sub1 category, but works for Server sub2 category

Actually, when we click on "server sub1" category, it moves to its child categories.

@mFlayyan
Copy link
Author

mFlayyan commented Oct 3, 2016

@pedrobaeza I think that my changes have not made that requirement of a one more depth level to see the megamenu , but you have a different structure of data on runbot than what you have on local DB ! and thus you see an awkward view that differs from yours!
this is what you have on runbot :
screenshot from 2016-10-03 12-07-17
and this what you have locally :
screenshot from 2016-10-03 12-07-42_local

@rafaelbn
Copy link
Member

rafaelbn commented Sep 2, 2019

Hi @mFlayyan please review this PR, you have comments.

cc #259 @remytms

@hbrunn
Copy link
Member

hbrunn commented Sep 2, 2019

@mFlayyan doesn't work for us any more and to my knowledge also not Odoo related any more, so I better close this PR I think

@hbrunn hbrunn closed this Sep 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants