New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[MIG][9.0][website_sale_vat_required] Migrate #174
Conversation
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes: - Moved from `OCA/website` to `OCA/e-commerce`. - Reduced license headers to new style ones, keeping copyright. - Updated README template. - Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon). - Benefit from upstream updates, that now handles incorrect VAT errors.
This addon is being moved to e-commerce. See OCA/e-commerce#174.
This addon is being moved to e-commerce. See OCA/e-commerce#174.
There is some problem with runbot not beign able to load the repo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please could you fix _get_optional_billing_fields of main controller.
return result | ||
|
||
def _get_optional_billing_fields(self): | ||
result = super(WebsiteSale, self)._get_mandatory_billing_fields() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This would be:
result = super(WebsiteSale, self)._get_optional_billing_fields()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good, thanks for fixing.
Funtional Ok.
Something strange has happened merging the PR, but the commits are there on 9.0, so I close. |
…ed-mig [MIG][9.0][website_sale_vat_required] Migrate
This addon is being moved to e-commerce. See OCA/e-commerce#174.
This addon is being moved to e-commerce. See OCA/e-commerce#174.
This addon got migrated from 8.0. Relevant notes:
OCA/website
toOCA/e-commerce
.@Tecnativa