Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG][9.0][website_sale_vat_required] Migrate #174

Closed
wants to merge 6 commits into from

Conversation

yajo
Copy link
Member

@yajo yajo commented May 4, 2017

This addon got migrated from 8.0. Relevant notes:

  • Moved from OCA/website to OCA/e-commerce.
  • Reduced license headers to new style ones, keeping copyright.
  • Updated README template.
  • Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon).
  • Benefit from upstream updates, that now handles incorrect VAT errors.

@Tecnativa

eLBati and others added 5 commits May 3, 2017 14:57
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes:

- Moved from `OCA/website` to `OCA/e-commerce`.
- Reduced license headers to new style ones, keeping copyright.
- Updated README template.
- Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon).
- Benefit from upstream updates, that now handles incorrect VAT errors.
@yajo yajo added this to the 9.0 milestone May 4, 2017
@yajo yajo self-assigned this May 4, 2017
@pedrobaeza pedrobaeza mentioned this pull request May 4, 2017
34 tasks
yajo added a commit to OCA/website that referenced this pull request May 4, 2017
yajo added a commit to OCA/website that referenced this pull request May 4, 2017
@pedrobaeza pedrobaeza mentioned this pull request May 4, 2017
17 tasks
@chienandalu
Copy link
Member

There is some problem with runbot not beign able to load the repo:

Unable to find image 'oca-e-commerce:ef9b678_3' locally
docker: Error response from daemon: repository oca-e-commerce not found: does not exist or no pull access.

Copy link

@felixvillafranca felixvillafranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please could you fix _get_optional_billing_fields of main controller.

return result

def _get_optional_billing_fields(self):
result = super(WebsiteSale, self)._get_mandatory_billing_fields()

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This would be:
result = super(WebsiteSale, self)._get_optional_billing_fields()

Copy link

@felixvillafranca felixvillafranca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good, thanks for fixing.
Funtional Ok.

@pedrobaeza
Copy link
Member

Something strange has happened merging the PR, but the commits are there on 9.0, so I close.

@pedrobaeza pedrobaeza closed this Jun 8, 2017
@pedrobaeza pedrobaeza deleted the 9.0-website_sale_vat_required-mig branch June 8, 2017 18:20
acsone-git-bot pushed a commit to acsone/e-commerce that referenced this pull request Jun 8, 2017
…ed-mig

[MIG][9.0][website_sale_vat_required] Migrate
lasley pushed a commit to LasLabs/website that referenced this pull request Jul 19, 2017
lasley pushed a commit to LasLabs/website that referenced this pull request Aug 11, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants