Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[10.0][MIG] website_sale_recently_viewed_products: Migration to 10.0 #184

Closed

Conversation

reinka
Copy link

@reinka reinka commented Jun 24, 2017

  • Migrated to v10.
  • Added phantomjs test

--
I confirm I have signed the CLA and read the PR guidelines at www.odoo.com/submit-pr

@pedrobaeza pedrobaeza mentioned this pull request Jun 24, 2017
15 tasks
@yajo yajo added this to the 10.0 milestone Jun 26, 2017
Copy link
Member

@yajo yajo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code review OK, just a little suggestion.

'<div class="popover-content"></div></div>'
}).on("mouseenter",function () {
'<div class="arrow"></div><h3 class="popover-title"></h3>' +
'<div class="popover-content"></div></div>'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better if you use a client-side qweb template and render it here.

@github-actions
Copy link

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

@github-actions github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Dec 19, 2021
@github-actions github-actions bot closed this Jan 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs review stale PR/Issue without recent activity, it'll be soon closed automatically.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants