Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MIG] website_sale_cart_selectable: Migration to 10.0 #192

Merged
merged 3 commits into from
Jul 24, 2017

Conversation

chienandalu
Copy link
Member

Website Sale Cart Selectable

This module was written to extend the functionality of the website to control
button add to cart. Button add to cart can now be set to be published or not.

cc @Tecnativa

@yajo yajo added this to the 10.0 milestone Jul 17, 2017
<field name="website_published" class="pull-right" widget="website_button" position="after">
<field name="website_btn_addtocart_published" class="pull-right" widget="website_button"/>
<field name="public_categ_ids" position="after">
<field name="website_btn_addtocart_published"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you remove the toggle widget?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza That widget is for stat buttons now. I could put this configuration in the button box, but I thought it belonged to the place where it used to be. I don't know if there is in v10 a widget similar to that one, do you?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, then change the README that tells about toggle.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pedrobaeza Changed

@pedrobaeza pedrobaeza mentioned this pull request Jul 21, 2017
15 tasks
Copy link

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some nitpicking

Website Sale Cart Selectable
============================

This module was written to extend the functionality of the website to control

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This module extends the functionality of the website to improve the control on the
button "Add to cart". Button "Add to cart" can now be set to be published or not.


To use this module, you need to:

1. Go to menu *Sales -> Products -> Products*

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you could also use "#. " (nice to have)

{
'name': 'Website Sale Cart Selectable',
'version': '10.0.1.0.0',
'summary': 'Enables to controlling button add to cart per product',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Enables to control button Add to cart display per product

@chienandalu chienandalu force-pushed the 10.0-mig-website_sale_cart_selectable branch from 3cf9e65 to c3788cc Compare July 21, 2017 08:18
@chienandalu
Copy link
Member Author

Thanks for your review @elicoidal 🙂 Changes done and commits squashed.

@lasley lasley merged commit ff61c12 into OCA:10.0 Jul 24, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants