10.0 porting website_sale_checkout_skip_payment #203

eLBati · 2017-09-04T09:15:37Z

No description provided.

simahawk · 2018-04-27T07:28:10Z

website_sale_checkout_skip_payment/README.rst

+Website Sale Checkout Skip Payment
+==================================
+
+This module allows to logged users to checkout with no payment step. At the


"allows logged users"

@simahawk done

simahawk · 2018-04-27T07:28:42Z

website_sale_checkout_skip_payment/README.rst

@@ -0,0 +1,63 @@
+.. image:: https://img.shields.io/badge/license-LGPL--3-blue.svg


@simahawk readme files re-created with new fragments

simahawk · 2018-04-27T07:29:00Z

website_sale_checkout_skip_payment/__manifest__.py

+{
+    'name': 'Website Sale Checkout Skip Payment',
+    'summary': 'Skip payment for logged users in checkout process',
+    'version': '10.0.0.1.0',


@simahawk done

simahawk · 2018-04-27T07:29:09Z

website_sale_checkout_skip_payment/__manifest__.py

+    'summary': 'Skip payment for logged users in checkout process',
+    'version': '10.0.0.1.0',
+    'category': 'Website',
+    'website': 'https://www.tecnativa.com',


https://github.com/OCA/e-commerce

@simahawk done

simahawk · 2018-04-27T07:30:03Z

website_sale_checkout_skip_payment/controllers/main.py

+
+    @http.route()
+    def payment_get_status(self, sale_order_id, **post):
+        # When skip payment step, the transaction not exists so only render


transaction does not exists

@simahawk done

simahawk · 2018-04-27T07:31:57Z

website_sale_checkout_skip_payment/models/website.py

+    @api.multi
+    def _compute_checkout_skip_payment(self):
+        for rec in self:
+            if request.session.uid:


just checking: is 100% that this is going to be recomputed for each user?
I'd rather use a std model method to get it not cached.

@simahawk just tested with 2 different users on 2 different browsers: it works

grindtildeath · 2018-04-27T09:51:29Z

I get this error when confirming an order through web shop :

2018-04-27 09:50:45,531 1 ERROR bssfw-24 odoo.http: Exception during JSON request handling.
Traceback (most recent call last):
  File "/opt/odoo/src/odoo/http.py", line 640, in _handle_exception
    return super(JsonRequest, self)._handle_exception(exception)
  File "/opt/odoo/src/odoo/http.py", line 677, in dispatch
    result = self._call_function(**self.params)
  File "/opt/odoo/src/odoo/http.py", line 333, in _call_function
    return checked_call(self.db, *args, **kwargs)
  File "/opt/odoo/src/odoo/service/model.py", line 101, in wrapper
    return f(dbname, *args, **kwargs)
  File "/opt/odoo/src/odoo/http.py", line 326, in checked_call
    result = self.endpoint(*a, **kw)
  File "/opt/odoo/src/odoo/http.py", line 935, in __call__
    return self.method(*args, **kw)
  File "/opt/odoo/src/odoo/http.py", line 506, in response_wrap
    response = f(*args, **kw)
  File "/opt/odoo/external-src/e-commerce/website_sale_checkout_skip_payment/controllers/main.py", line 35, in payment_get_status
    'message': request.website._render(
AttributeError: 'website' object has no attribute '_render'

rafaelbn · 2018-04-28T23:08:43Z

Hi @eLBati thanks for this migration! Please could you check comments? Thanks

rafaelbn · 2018-10-06T21:16:39Z

Hello @eLBati could you review comments? Are you interested in continuing this PR?

The v11 migration is here 11.0 mig website sale checkout skip payment #228
We did it duplicated in [MIG] website_sale_checkout_skip_payment: Migration to 11.0 #246 ☯️
You should take care of [9.0][FIX] website_sale_checkout_skip_paymen: Message error in checkout confirmation step when partner is has skip payment flag #223
Check comments from @simahawk

Let me know! 😃

…ment step in checkout process

OCA Transbot updated translations from Transifex

…ut confirmation step when partner is has skip payment flag (#1)

eLBati · 2018-10-09T12:52:41Z

@grindtildeath can you describe the steps to reproduce the error? I am not able to reproduce it in a standard scenario

eLBati · 2018-10-09T12:55:23Z

@rafaelbn thanks, #223 is already included with e26b2c5

grindtildeath

@eLBati Tested again and seems to work, so approved.

grindtildeath · 2018-10-09T16:15:07Z

@eLBati My bad, but while switching off my local instances, I just see I had the same error in my server logs, I'll try to give it another look tomorrow.

grindtildeath · 2018-10-10T07:43:41Z

@eLBati Just tested again and this happens when confirming the order on the webshop with a user having skip payment activated. The UX looks ok, but we get this error in the logs.

FIX website_sale_checkout_skip_payment/controllers/main.py", line 35, in payment_get_status 'message': request.website._render( AttributeError: 'website' object has no attribute '_render'

eLBati · 2018-10-11T08:04:54Z

@grindtildeath thanks, fixed

fuentes73

Using it in production since a while and everything works OK.

rafaelbn · 2019-10-02T15:45:14Z

/ocabot merge

OCA-git-bot · 2019-10-02T15:45:29Z

On my way to merge this fine PR!
Prepared branch 10.0-ocabot-merge-pr-203-by-rafaelbn-bump-no, awaiting test results.

Signed-off-by rafaelbn

OCA-git-bot · 2019-10-02T16:19:14Z

@rafaelbn your merge command was aborted due to failed check(s), which you can inspect on this commit of 10.0-ocabot-merge-pr-203-by-rafaelbn-bump-no.

After fixing the problem, you can re-issue a merge command. Please refrain from merging manually as it will most probably make the target branch red.

zeroheure · 2021-11-26T13:01:21Z

Why this was never merged ?

github-actions · 2022-03-27T12:25:05Z

There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days.
If you want this PR to never become stale, please ask a PSC member to apply the "no stale" label.

eLBati mentioned this pull request Sep 4, 2017

Migration to version 10.0 #133

Closed

15 tasks

yajo added the needs review label Sep 5, 2017

yajo added this to the 10.0 milestone Sep 5, 2017

larmar mentioned this pull request Dec 24, 2017

11.0 mig website sale checkout skip payment #228

Merged

tafaRU approved these changes Jan 24, 2018

View reviewed changes

simahawk requested changes Apr 27, 2018

View reviewed changes

sergio-teruel and others added 5 commits October 9, 2018 14:36

[9.0][WIP] website_sale_checkout_skip_payment: New module to skip pay…

c765c71

…ment step in checkout process

[IMP] website_sale_checkout_skip_payment: Texts + code

ca34e95

OCA Transbot updated translations from Transifex

591d862

OCA Transbot updated translations from Transifex

Porting website_sale_checkout_skip_payment to 10.0

a4374c0

[9.0][FIX] website_sale_checkout_skip_paymen: Message error in checko…

efb4e7c

…ut confirmation step when partner is has skip payment flag (#1)

eLBati force-pushed the 10.0-mig-website_sale_checkout_skip_payment branch from e26b2c5 to 6f67dbc Compare October 9, 2018 12:56

grindtildeath reviewed Oct 9, 2018

View reviewed changes

grindtildeath approved these changes Oct 9, 2018

View reviewed changes

IMP README files and meta data

e0f9216

FIX website_sale_checkout_skip_payment/controllers/main.py", line 35, in payment_get_status 'message': request.website._render( AttributeError: 'website' object has no attribute '_render'

eLBati force-pushed the 10.0-mig-website_sale_checkout_skip_payment branch from 6f67dbc to e0f9216 Compare October 11, 2018 08:04

fuentes73 approved these changes Oct 2, 2019

View reviewed changes

OCA-git-bot added a commit that referenced this pull request Oct 2, 2019

Merge PR #203 into 10.0

fce8516

Signed-off-by rafaelbn

github-actions bot added the stale PR/Issue without recent activity, it'll be soon closed automatically. label Mar 27, 2022

github-actions bot closed this May 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

10.0 porting website_sale_checkout_skip_payment #203

10.0 porting website_sale_checkout_skip_payment #203

eLBati commented Sep 4, 2017

simahawk Apr 27, 2018

eLBati Oct 9, 2018

simahawk Apr 27, 2018

eLBati Oct 9, 2018

simahawk Apr 27, 2018

eLBati Oct 9, 2018

simahawk Apr 27, 2018

eLBati Oct 9, 2018

simahawk Apr 27, 2018

eLBati Oct 9, 2018

simahawk Apr 27, 2018

eLBati Oct 9, 2018

grindtildeath commented Apr 27, 2018

rafaelbn commented Apr 28, 2018

rafaelbn commented Oct 6, 2018

eLBati commented Oct 9, 2018

eLBati commented Oct 9, 2018

grindtildeath left a comment

grindtildeath commented Oct 9, 2018

grindtildeath commented Oct 10, 2018

eLBati commented Oct 11, 2018

fuentes73 left a comment

rafaelbn commented Oct 2, 2019

OCA-git-bot commented Oct 2, 2019

OCA-git-bot commented Oct 2, 2019

zeroheure commented Nov 26, 2021

github-actions bot commented Mar 27, 2022

		@@ -0,0 +1,63 @@
		.. image:: https://img.shields.io/badge/license-LGPL--3-blue.svg

10.0 porting website_sale_checkout_skip_payment #203

10.0 porting website_sale_checkout_skip_payment #203

Conversation

eLBati commented Sep 4, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

grindtildeath commented Apr 27, 2018

rafaelbn commented Apr 28, 2018

rafaelbn commented Oct 6, 2018

eLBati commented Oct 9, 2018

eLBati commented Oct 9, 2018

grindtildeath left a comment

Choose a reason for hiding this comment

grindtildeath commented Oct 9, 2018

grindtildeath commented Oct 10, 2018

eLBati commented Oct 11, 2018

fuentes73 left a comment

Choose a reason for hiding this comment

rafaelbn commented Oct 2, 2019

OCA-git-bot commented Oct 2, 2019

OCA-git-bot commented Oct 2, 2019

zeroheure commented Nov 26, 2021

github-actions bot commented Mar 27, 2022