[11.0][MIG] website_sale_require_login: basic mig from v10 to v11 #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please one module per PR and take into account #222 |
|
will do two PRs, i can see #222 is approved, merge in order to rebase please |
oscarolar
force-pushed
the
11.0-migrate_sale_require_login_10-2-11
branch
from
355dc75
to
9b17cbd
Compare
|
Depends on #225 to satisfy dependency tree |
pedrobaeza
changed the title
|
Usually OCA requires to keep original commit history. Check https://github.com/OCA/maintainer-tools/wiki/Migration-to-version-11.0#technical-method-to-migrate-a-module-from-100-to-110-branch |
|
I was about to say it 😉 |
|
|
oscarolar
force-pushed
the
11.0-migrate_sale_require_login_10-2-11
branch
from
160f6c3
to
8d5634e
Compare
Example of module which requires such refactoring: https://github.com/it-projects-llc/website-addons/tree/10.0/website_sale_checkout_store [FIX] condition to show normal checkout button was wrong in website_sale_suggest_create_account I was equal to (user_authenticated or not signup_allowed and can_checkout) while it has to be (user_authenticated or not signup_allowed) and can_checkout
oscarolar
force-pushed
the
11.0-migrate_sale_require_login_10-2-11
branch
2 times, most recently
from
e602a6c
to
059bb23
Compare
oscarolar
force-pushed
the
11.0-migrate_sale_require_login_10-2-11
branch
from
059bb23
to
a456d9c
Compare
|
@yajo this is pretty much ready to review |
yajo
approved these changes
Feb 5, 2018
|
Functional and code review 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on