11.0 mig website sale affiliate #232
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [ADD] website_sale_affiliate: Create module * Add sale.affiliate and sale.affiliate.request models * Override WebsiteSale controller shop method to store affiliate id & key kwargs of shop urls in session * Override sale order create method to store affiliate request * Add affiliate and request views, links in Sales/Affiliates * Add affiliate_request_id to sale.order form view * Add request sequence record, make default for new affiliates * Add access rights to sales users/managers * Add tests * Add readme instructions * [IMP] website_sale_affiliate: Make requested changes * Update readme * Add controller override to catch product urls * Remove redundant return None * Replace if statements with try/except when appropriate * Change api decorator on sale.affiliate.find_from_session method from model -> model_cr_context * Add check to avoid unnecessary db search in find_from_session if no affiliate_id * Fix tests * Add new tests * [IMP] website_sale_affiliate: Make requested changes * Un-nest try/except statements for readability * Rename kwargs: ref, key -> aff_ref, aff_key * Improve request search speed for large recordsets * Document similarly-named methods for clarity * Tweak tests as needed * Add additional test * Add roadmap to readme * [REM] website_sale_affiliate: Remove affiliate request IP-matching * [IMP] website_sale_affiliate: Change affiliate request creation * Create affiliate requests regardless of whether a sale occurs * Add basic conversion/sales stats to affiliate model and views * Update tests * Add demo data * Clean up views * Remove line used for debugging * Add field string for clarity * [FIX] website_sale_affiliate: Fix compatibility issues, tests * Fix controller method overrides to avoid conflicts * Match assertAlmostEqual decimal places to amount used in fields * Remove/replace tests with unneeded url_open calls * Rename files, variables for clarity * Clean up demo/test data * [IMP] website_sale_affiliate: Clarify affiliate request name * Add help to name field on affiliate request model
|
Please check Travis |
|
Hi @DarkoNikolovski , travis is red says: Could you check it please? thanks for this contribution!!!!! 😄 |
|
Sorry, I have missed the previous comment. Should be fine now. |
MeetKD
reviewed
May 30, 2018
| "version": "11.0.1.0.0", | ||
| "category": "Website", | ||
| "website": "https://laslabs.com", | ||
| "author": "LasLabs, Odoo Community Association (OCA), Versada", |
There was a problem hiding this comment.
'website': 'https://github.com/OCA/e-commerce',
|
Please @DarkoNikolovski review website and we can merge! #232 (comment) Thanks! |
|
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
github-actions
bot
added
the
stale
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.