11.0 mig website_sale_vat_required #236
Conversation
There was a problem hiding this comment.
- Check Travis
- Use the new OCA readme system: https://github.com/OCA/maintainer-tools/tree/master/template/module/readme
| 'author': "Agile Business Group, " | ||
| "Tecnativa, " | ||
| "Odoo Community Association (OCA)", | ||
| 'website': 'http://www.agilebg.com', |
There was a problem hiding this comment.
|
cc @Tecnativa |
| /* Copyright 2017 Jairo Llopis <jairo.llopis@tecnativa.com> | ||
| * License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). */ | ||
|
|
||
| odoo.define('website_sale_vat_required.tour', function (require) { |
There was a problem hiding this comment.
If you remove this patch, then the website_sale main tour fails (as it's happening right now)
| <xpath expr="//input[@name='vat']/.." position="replace"/> | ||
| <xpath expr="//input[@name='company_name']/../.." position="after"> | ||
| <t t-if="mode[1] == 'billing'"> | ||
| <div t-attf-class="form-group #{error.get('vat') and 'has-error' or ''} col-md-6 div_vat"> |
There was a problem hiding this comment.
Good question. It seems included upstream already.
There was a problem hiding this comment.
This migration has been made from v9 directly . In v9 the only thing you need to do is set 'vat' as mandatory field using _get_mandatory_billing_fields method. In v10 and v11, if you only do that and you don't modify the template 'address', then, when an user is logged in, odoo will not permit to complete the form until this field is filled, but this field will be hide and the user will wonder what happened. This is, because now, odoo only show this field if there is no user logged in.
There was a problem hiding this comment.
That's interesting. So, Odoo doesn't let a user modify his VAT number. IMHO that makes sense; if you need to change such field, you're probably better creating a new customer.
Then maybe you should only require vat when he's adding a new address. I think you can check that by making sure there's no request.params["partner_id"].
| 'base_vat', | ||
| ], | ||
| 'demo': [ | ||
| 'views/templates.xml', |
There was a problem hiding this comment.
This is not a demo file. Either put it in the demo folder or in the data key.
| <xpath expr="//input[@name='vat']/.." position="replace"/> | ||
| <xpath expr="//input[@name='company_name']/../.." position="after"> | ||
| <t t-if="mode[1] == 'billing'"> | ||
| <div t-attf-class="form-group #{error.get('vat') and 'has-error' or ''} col-md-6 div_vat"> |
There was a problem hiding this comment.
Good question. It seems included upstream already.
|
Please @pedrobaeza @yajo could you update you reviews after last commits? Thanks! |
|
@ernestotejeda please review travis 🔴 thanks! |
|
You need to fix the test: https://travis-ci.org/OCA/e-commerce/jobs/388963897#L3102 |
| * `Tecnativa <https://www.tecnativa.com>`_: | ||
|
|
||
| * Jairo Llopis <jairo.llopis@tecnativa.com> | ||
| * Ernesto Tejeda <ernesto.tejeda87@gmail.com> |
There was a problem hiding this comment.
You shouldn't put your personal e-mail here. In fact, we are even removing our corporate ones in all places. I'm changing this myself if the rest is correct.
|
Travis is failing. Please check that and make the change about the email address. |
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes: - Moved from `OCA/website` to `OCA/e-commerce`. - Reduced license headers to new style ones, keeping copyright. - Updated README template. - Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon). - Benefit from upstream updates, that now handles incorrect VAT errors.
pedrobaeza
force-pushed
the
11.0-mig-website_sale_vat_required
branch
from
e0531f9
to
b844d8e
Compare
cc @Tecnativa