-
-
Notifications
You must be signed in to change notification settings - Fork 482
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
11.0 mig website_sale_default_country #239
11.0 mig website_sale_default_country #239
Conversation
- Relicensed to LGPL. The rest is a normal migration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Functional test ok. Just some little comments.
- Try to use the new OCA readme system: https://github.com/OCA/maintainer-tools/tree/master/template/module/readme
- Put yourself in contributors credits 😉
"summary": "Give a default value for country at checkout", | ||
"version": "11.0.1.0.0", | ||
"category": "Website", | ||
"website": "https://www.tecnativa.com", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested functionally 👍
Please review codecov/patch — 57.14% of diff hit (target 100%)
cc @Tecnativa |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved when you attend #239 (review), please.
Thanks!
Testing this is a total nightmare with current PhantomJS tour system, so leave it as is. Please attend chienandalu's comment about README + contribution (check other one I have just submitted in your PRs as example). |
Actually it was a nightmare until odoo 9. From v10, the tour system works fine, and from v11 we even have a new testing system (I haven't used it yet, though, and it's mostly for widgets, but it's awesome). The pain now comes from tests is not much different from the pain of writing tests we always have had. Clarifying that, it's not like I'm asking for tests here; although it would be great indeed 😊 |
@ernestotejeda this is ready to merge; please squash migration commits in 1 to do it. Thanks! |
1da7006
to
04a416b
Compare
cc @Tecnativa