11.0 mig website sale hide price #241
Conversation
There was a problem hiding this comment.
Thanks for the work!
Please use the new OCA readme system: https://github.com/OCA/maintainer-tools/blob/master/template/module/README.rst
| @@ -1,4 +1,6 @@ | |||
| # -*- coding: utf-8 -*- | |||
There was a problem hiding this comment.
This is not needed in python 3
|
|
||
| ############################################################################## | ||
| # For copyright and license notices, see __openerp__.py file in root directory | ||
| ############################################################################## |
There was a problem hiding this comment.
Why adding this? Delete it, please
| @@ -10,5 +10,4 @@ class ResPartner(models.Model): | |||
|
|
|||
| website_show_price = fields.Boolean( | |||
| string='Show prices on website', | |||
| default=True, | |||
| ) | |||
| default=True) | |||
There was a problem hiding this comment.
Don't change coding style unnecesarily
| @@ -16,3 +17,5 @@ def _compute_website_show_price(self): | |||
| for rec in self: | |||
| rec.website_show_price = ( | |||
| request.env.user.partner_id.website_show_price) | |||
|
|
|||
| @@ -1,5 +1,6 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright 2017 Tecnativa - David Vidal | |||
| # Copyright 2018 Trey, kilobytes de soluciones - Abraham Gonzalez | |||
There was a problem hiding this comment.
Credit yourself just if you make remarkable changes to the file.
website_sale_hide_price/__init__.py
Outdated
| @@ -1,3 +1,2 @@ | |||
| # -*- coding: utf-8 -*- | |||
| @@ -1,11 +1,13 @@ | |||
| # -*- coding: utf-8 -*- | |||
| # Copyright 2017 Tecnativa - David Vidal | |||
| # Copyright 2018 Trey, kilobytes de soluciones - Abraham Gonzalez | |||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | |||
| { | |||
| 'name': 'Website Sale Hide Price', | |||
| 'version': '10.0.1.0.0', | |||
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
| { | ||
| 'name': 'Website Sale Hide Price', | ||
| 'version': '10.0.1.0.0', | ||
| 'category': 'Website', | ||
| 'author': 'Tecnativa, ' | ||
| 'author': 'Trey, Kilobytes de soluciones, ' | ||
| 'Tecnativa, ' | ||
| 'Odoo Community Association (OCA)', | ||
| 'website': 'https://www.tecnativa.com', |
There was a problem hiding this comment.
| # License AGPL-3.0 or later (http://www.gnu.org/licenses/agpl). | ||
| { | ||
| 'name': 'Website Sale Hide Price', | ||
| 'version': '10.0.1.0.0', | ||
| 'category': 'Website', | ||
| 'author': 'Tecnativa, ' | ||
| 'author': 'Trey, Kilobytes de soluciones, ' |
There was a problem hiding this comment.
As no remarkable changes have been done in the migration, your credits should go to the readme
| 'name': 'Website Sale Hide Price', | ||
| 'version': '10.0.1.0.0', | ||
| 'category': 'Website', | ||
| 'author': 'Trey, Kilobytes de soluciones, ' |
There was a problem hiding this comment.
You shouldn't add your company here unless you make significant changes on the module, which is not the case.
|
@chienandalu please finish your review |
pedrobaeza
force-pushed
the
11.0-mig-website_sale_hide_price
branch
from
8f9781e
to
ffc4b85
Compare
[MIG] website_sale_hide_price: Migration to 11.0