[12.0] [MIG] website_sale_vat_required #255
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bouvyd
commented
Oct 29, 2018
bouvyd
commented
- removed js tour that was nowhere in the assets (and thus never loaded)
- adapted to BS4 class names
[FIX] Depend on vat validation module that causes the VAT number field to be displayed at checkout in the first place
This addon got migrated from 8.0. Relevant notes: - Moved from `OCA/website` to `OCA/e-commerce`. - Reduced license headers to new style ones, keeping copyright. - Updated README template. - Replaced dirty hack that disables addon in test mode, and hack the tour instead (actually testing the addon). - Benefit from upstream updates, that now handles incorrect VAT errors.
- removed js tour that was nowhere in the assets (and thus never loaded) - adapted to BS4 class names
19 tasks
Tardo
suggested changes
Jun 16, 2019
| <template id="website_sale_vat_required_assets_frontend_demo" inherit_id="website_sale.assets_frontend"> | ||
| <xpath expr="//script[last()]" position="after"> | ||
| <script type="text/javascript" | ||
| src="/website_sale_vat_required/static/src/js/website_sale_vat_required.tour.js"/> |
chienandalu
suggested changes
Jun 17, 2019
|
Superseded by #302 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.