-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[11.0][ADD] website_sale_ecommerce_description: Add a description only for the e-commerce #266
[11.0][ADD] website_sale_ecommerce_description: Add a description only for the e-commerce #266
Conversation
'name': 'Website Sale e-Commerce Description', | ||
'category': 'Website', | ||
'summary': 'Add a e-Commerce description', | ||
'version': '11.0.1.0.1', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change version to 11.0.1.0.0
https://github.com/OCA/odoo-community.org/blob/master/website/Contribution/CONTRIBUTING.rst#version-numbers
</xpath> | ||
</template> | ||
|
||
</odoo> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add blank line
<xpath expr="//div[p[@t-field='product.description_sale']]" position="after"> | ||
<hr t-if="product.description_ecommerce" /> | ||
<div class="o_not_editable"> | ||
<p t-field="product.description_ecommerce" class="text-muted" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If the user write description_sale field, both fields appears in the views? Is this behavior expected?
'e-Commerce description', | ||
help='A description of the Product. This description will be displayed' | ||
' only on your e-Commerce.' | ||
) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make field translatable
e9ddc10
to
06707e5
Compare
Hi @sylvainvh, please take a look at #442 , I think is quite similar to this PR on v12. Thanks! |
There hasn't been any activity on this pull request in the past 4 months, so it has been marked as stale and it will be closed automatically if no further activity occurs in the next 30 days. |
The field sale description on the product is displayed on the ecommerce but also on other reports (invoice, sale order ...). This module will allow to add a description only for the ecommerce.