[12.0][MIG] website_sale_require_legal: Migration to v12

[cristinamartinrod]

cc @Tecnativa

[yajo]

Code looks OK, but just a couple of details:

Apart from that, clicking any of them while unauthenticated directs me to a 404 error:

[cristinamartinrod]

@yajo This is something from v12. It's because there are times that the cart can be very long and this a more visible option in the part on the right. And I suppose that the use of different colors is to only focus attention in one of them, that is usually something normal.

The 404 error seems to be something of runbot because if you uninstall the module it continues to happen and it doesn't seem to have any additional associated permission in the module. On local I didn't detected that error. Could it be that? Is it crazy?

[yajo]

This is something from v12. It's because there are times that the cart can be very long and this a more visible option in the part on the right. And I suppose that the use of different colors is to only focus attention in one of them, that is usually something normal.

True, I didn't see it before!

OK then.

The 404 error seems to be something of runbot because

Possibly you need to enable signup in the website. I think it's done from its settings.

I don't know if it's done now via ir.config_parameter for all websites, or is it done per website. Check it out and:

• If it's global, enable it automatically when installing the addon.
• If it's per website, add the instructions to the configuration section of the README, and do not display the button in websites that have it disabled.

[pedrobaeza]

Shouldn't we activate it when installing this module?

[yajo]

Yes, if it's global, but if it's per website, then IMHO we should leave that option untouched.

[pedrobaeza]

If not, it should be properly documented

[yajo]

The tour is failing. You'll have to update some step probably.

[yajo]

Tests fixed

[pedrobaeza]

I'm afraid not

[yajo]

I restarted https://travis-ci.org/OCA/e-commerce/builds/437949375 because I suspect it's the main branch that's broken.

[pedrobaeza]

Yes, main branch is also red. Please check and fix it.

[yajo]

Fix in #281.

[pedrobaeza]

Please rebase

[yajo]

Done, let's see travis.