-
-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
12.0 mig website_sale_default_country #285
12.0 mig website_sale_default_country #285
Conversation
- Relicensed to LGPL. The rest is a normal migration.
09e7cd6
to
4eea177
Compare
Seeing this code, I consider this module as not needed: |
What do you think, @Tardo? |
This module is usefull if you want have a country on all situations... without this module country_id can be "False" (Users without country_id defined) |
@Tardo not really, as you are using the public user associated to the website, so it's your duty to assign to that user the country. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tested the flow setting a default country at the Public User in Odoo standard and I agree with @pedrobaeza that this seems to be uneeded from this version
It's true, I tested the flow setting to default country at the Public User and it works fine. I even tried it locally in v11 and v10 and it works fine as well, so I think in v11 and v10 it's not necessary, either :) :) Anyway, I'm going to test now how compatible this is with multiwebsite |
Yes, it works well for multi-website in odoo 12 with the public user. Looking a bit at the code, I have seen that each website is related to a user and that user is the user that is related to the company to which the website belongs |
I tested also with multicompany and is covered in standard as well |
Well, closing then as unneeded. It'd be good psosibly to have an OpenUpgrade migration script where this is merged into |
You need to merge the module in OpenUpgrade. |
Cc @Tecnativa