Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

12.0 mig website_sale_default_country #285

Closed

Conversation

ernestotejeda
Copy link
Member

  • readme by fragments

Cc @Tecnativa

@pedrobaeza pedrobaeza added this to the 12.0 milestone May 11, 2019
@OCA-git-bot OCA-git-bot mentioned this pull request May 11, 2019
19 tasks
@pedrobaeza pedrobaeza force-pushed the 12.0-mig-website_sale_default_country branch from 09e7cd6 to 4eea177 Compare May 11, 2019 13:19
@pedrobaeza
Copy link
Member

@pedrobaeza
Copy link
Member

What do you think, @Tardo?

@Tardo
Copy link
Member

Tardo commented May 14, 2019

This module is usefull if you want have a country on all situations... without this module country_id can be "False" (Users without country_id defined)

@pedrobaeza
Copy link
Member

@Tardo not really, as you are using the public user associated to the website, so it's your duty to assign to that user the country.

Copy link
Member

@chienandalu chienandalu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested the flow setting a default country at the Public User in Odoo standard and I agree with @pedrobaeza that this seems to be uneeded from this version

@ernestotejeda
Copy link
Member Author

It's true, I tested the flow setting to default country at the Public User and it works fine. I even tried it locally in v11 and v10 and it works fine as well, so I think in v11 and v10 it's not necessary, either :) :)

Anyway, I'm going to test now how compatible this is with multiwebsite

@ernestotejeda
Copy link
Member Author

Yes, it works well for multi-website in odoo 12 with the public user. Looking a bit at the code, I have seen that each website is related to a user and that user is the user that is related to the company to which the website belongs

@chienandalu
Copy link
Member

I tested also with multicompany and is covered in standard as well

@yajo
Copy link
Member

yajo commented May 29, 2019

Well, closing then as unneeded. It'd be good psosibly to have an OpenUpgrade migration script where this is merged into website_sale.

@yajo yajo closed this May 29, 2019
@yajo yajo deleted the 12.0-mig-website_sale_default_country branch May 29, 2019 07:18
@pedrobaeza
Copy link
Member

You need to merge the module in OpenUpgrade.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants