[12.0][MIG] website_sale_checkout_country_vat #286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e in website checkout form.
Replace settings with sane defaults. Update VAT flag when address country is updated.
If you leave country field empty before pressing the confirm button at checkout, you were getting a 500 error because `country_id` was `""` (str), which cannot be searched in an int field. Now we set a default `False` value, which will return an empty recordset without that problem.
Tardo
force-pushed
the
12.0-mig-website_sale_checkout_country_vat
branch
from
0aa8544
to
eb2681d
Compare
|
Runbot fails because missing dependencies.... (are in other repo and not merged into 12.0) |
pedrobaeza
requested changes
May 13, 2019
|
About Travis tests, can be due to this module. |
Tardo
force-pushed
the
12.0-mig-website_sale_checkout_country_vat
branch
from
24991f4
to
dcc7c09
Compare
|
I still get 404 page when I click in "Sign up and checkout". Is it due to this module? I have been able however to see the country dropdown when editing the address once logged-in. |
Tardo
force-pushed
the
12.0-mig-website_sale_checkout_country_vat
branch
from
dcc7c09
to
203e4be
Compare
|
Dropped oca_dependencies changes. |
yajo
requested changes
May 17, 2019
Tardo
force-pushed
the
12.0-mig-website_sale_checkout_country_vat
branch
from
203e4be
to
7e11ef6
Compare
|
Reverted "$target" changes |
|
@pedrobaeza The problem is that "website_sale_suggest_create_account" module fails on runbot... I installed it on local and works :/ |
|
Please check with @yajo what can be the problem. |
|
Although I'm now seeing that this PR is green. |
pedrobaeza
approved these changes
May 17, 2019
yajo
approved these changes
May 17, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Normal migration... Odoo 12.0 doesn't have "vat" as required field.